[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ppcr2rx3kkm5iiykbagv67fqmyoounmvdgscbd5d3t5e42ym2i@37csodg3qbap>
Date: Tue, 24 Sep 2024 10:46:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: andi.shyti@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, tsbogend@...ha.franken.de, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: i2c: Add RTL9300 I2C controller
On Tue, Sep 24, 2024 at 11:02:28AM +1200, Chris Packham wrote:
> Add dtschema for the I2C controller on the RTL9300 SoC. The I2C
> controllers on this SoC are part of the "switch" block which is
> represented here as a syscon node. The SCL pins are dependent on the I2C
> controller (GPIO8 for the first controller, GPIO 17 for the second). The
> SDA pins can be assigned to either one of the I2C controllers (but not
> both).
>
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v3:
> - Remove parent node in example
> - put unevaluatedProperties after required
> - Add #address-cells and #size-cells
>
> Changes in v2:
> - Use reg property for controller registers
> - Remove global-control-offset (will be hard coded in driver)
> - Integrated the multiplexing function. Child nodes now represent the
> available SDA lines
>
> .../bindings/i2c/realtek,rtl9300-i2c.yaml | 80 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 86 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml
>
> diff --git a/Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml b/Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml
> new file mode 100644
> index 000000000000..979ec22e81f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/realtek,rtl9300-i2c.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/realtek,rtl9300-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek RTL I2C Controller
> +
> +maintainers:
> + - Chris Packham <chris.packham@...iedtelesis.co.nz>
> +
> +description:
> + The RTL9300 SoC has two I2C controllers. Each of these has an SCL line (which
> + if not-used for SCL can be a GPIO). There are 8 common SDA lines that can be
> + assigned to either I2C controller.
> +
> +properties:
> + compatible:
> + const: realtek,rtl9300-i2c
You need SoC-specific compatibles in the front followed by this
fallback. For each SoC.
Best regards,
Krzysztof
Powered by blists - more mailing lists