linux-kernel - Re: [PATCH v4 1/3] dt-bindings: mfd: Add Realtek switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c19de70-abab-469b-afd0-f585cc807e04@kernel.org>
Date: Tue, 24 Sep 2024 10:51:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: lee@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 tsbogend@...ha.franken.de, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: mfd: Add Realtek switch

On 24/09/2024 10:39, Krzysztof Kozlowski wrote:
> On Tue, Sep 24, 2024 at 10:57:17AM +1200, Chris Packham wrote:
>> Add device tree schema for the Realtek switch. Currently the only
>> supported feature is the syscon-reboot which is needed to be able to
>> reboot the board.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
> 

Unreviewed - it is incomplete!

No, we said multiple times, you must send complete binding. Sending
pieces for review does not give us full picture and hides parts of the
controversial decisions. If you want to go this way, next time you will
get NAK when adding i2c@0-7 to parent binding.

Best regards,
Krzysztof