lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <831dbda0-f787-43d5-b771-c837412be10b@ysoft.com>
Date: Tue, 24 Sep 2024 11:08:32 +0200
From: Michal Vokáč <michal.vokac@...ft.com>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Shawn Guo <shawnguo@...nel.org>, Petr Benes <petr.benes@...ft.com>,
 devicetree@...r.kernel.org, linux-usb@...r.kernel.org,
 Michael Walle <mwalle@...nel.org>, imx@...ts.linux.dev,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Mathieu Othacehe <m.othacehe@...il.com>,
 Hugo Villeneuve <hvilleneuve@...onoff.com>, linux-kernel@...r.kernel.org,
 Hiago De Franco <hiago.franco@...adex.com>,
 Herburger <gregor.herburger@...tq-group.com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Joao Paulo Goncalves <joao.goncalves@...adex.com>,
 Fabio Estevam <festevam@...il.com>, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 4/4] arm64: dts: imx8mp-iota2: Enable the USB Type-C
 port

On 24. 09. 24 9:23, Marco Felsch wrote:
> On 24-09-23, Michal Vokáč wrote:
>> From: Petr Benes <petr.benes@...ft.com>
>>
>> Enable the USB Type-C port with the Diodes PI5USB30213A port controller.
>> The port supports dual role data but can operate only in source power role
>> and PD is not supported.
>>
>> Signed-off-by: Petr Benes <petr.benes@...ft.com>
>> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>
>> ---
>> v3:
>> - none
>> v2:
>> - Use typec instead of tcpc.
>> - Drop unneeded status.
>>
>>   .../boot/dts/freescale/imx8mp-iota2-lumpy.dts | 94 +++++++++++++++++++
>>   1 file changed, 94 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts b/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
>> index 120e6b87a000..bfed410339a4 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
>> @@ -32,6 +32,17 @@ button-reset {
>>   		};
>>   	};
>>   
>> +	reg_typec: regulator-typec {
>> +		compatible = "regulator-fixed";
>> +		enable-active-high;
>> +		gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>;
> 
> Can you please put the enable-active-high and gpio property below the
> regualtor-* properties?

Sure.

>> +		pinctrl-0 = <&pinctrl_usbc_vbus>;
>> +		pinctrl-names = "default";
>> +		regulator-max-microvolt = <5000000>;
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-name = "typec";
>> +	};
>> +
>>   	reg_usb_host: regulator-usb-host {
>>   		compatible = "regulator-fixed";
>>   		enable-active-high;

>> @@ -389,15 +451,47 @@ &uart2 {
>>   	status = "okay";
>>   };
>>   
>> +&usb3_0 {
>> +	status = "okay";
>> +};
>> +
>>   &usb3_1 {
>>   	status = "okay";
>>   };
>>   
>> +&usb3_phy0 {
>> +	status = "okay";
>> +};
>> +
>>   &usb3_phy1 {
>>   	vbus-supply = <&reg_usb_host>;
>>   	status = "okay";
>>   };
>>   
>> +&usb_dwc3_0 {
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>> +	dr_mode = "otg";
>> +	usb-role-switch;
>> +	status = "okay";
>> +
> 
> 	ports {
> 		#address-cells = <1>;
> 		#size-cells = <0>;

OK.

>> +	port@0 {
>> +		reg = <0>;
>> +
>> +		typec_hs: endpoint {
>> +			remote-endpoint = <&usb_con_hs>;
>> +		};
>> +	};
>> +
>> +	port@1 {
>> +		reg = <1>;
>> +
>> +		typec_ss: endpoint {
>> +			remote-endpoint = <&usb_con_ss>;
>> +		};
>> +	};
> 
> 	}
> 
> 	like you did for the connector node.

OK, I will do so.
Thank you for the review,
Michal

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ