[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <15288441.JCcGWNJJiE@phil>
Date: Tue, 24 Sep 2024 12:01:23 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: vkoul@...nel.org, kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, Frank Wang <frawang.cn@...il.com>
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org, william.wu@...k-chips.com,
tim.chen@...k-chips.com, wmc@...k-chips.com,
Frank Wang <frank.wang@...k-chips.com>
Subject:
Re: [PATCH v2 2/2] phy: rockchip: inno-usb2: Add usb2 phys support for rk3576
Am Dienstag, 24. September 2024, 10:55:10 CEST schrieb Frank Wang:
> From: William Wu <william.wu@...k-chips.com>
>
> The RK3576 SoC has two independent USB2.0 PHYs, and
> each PHY has one port.
Can you please split the content into "converting to clk_bulk" (see
additional comment below) and "add rk3576" please?
That would make the patch a lot cleaner.
> @@ -376,6 +378,7 @@ rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy)
> {
> struct device_node *node = rphy->dev->of_node;
> struct clk_init_data init;
> + struct clk *refclk = of_clk_get_by_name(node, "phyclk");
Doesn't this create an imbalance - with the missing put?
I think ideally just define clk_bulk_data structs for the
1-clock and 3-clock variant, attach that to the device-data
and then use the regular devm_clk_bulk_get ?
That way you can then retrieve the clock from that struct?
Thanks
Heiko
Powered by blists - more mailing lists