linux-kernel - RE: [PATCH v3 2/3] drm/bridge: it6505: HDCP CTS fail on repeater items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169c171660ac4897903aef5befc780db@ite.com.tw>
Date: Tue, 24 Sep 2024 02:57:10 +0000
From: <Hermes.Wu@....com.tw>
To: <dmitry.baryshkov@...aro.org>
CC: <treapking@...omium.org>, <Kenneth.Hung@....com.tw>,
        <andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>,
        <rfoss@...nel.org>, <Laurent.pinchart@...asonboard.com>,
        <jonas@...boo.se>, <jernej.skrabec@...il.com>,
        <maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
        <tzimmermann@...e.de>, <airlied@...il.com>, <simona@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 2/3] drm/bridge: it6505: HDCP CTS fail on repeater
 items

>On Mon, Sep 23, 2024 at 10:45:49AM GMT, Hermes.Wu@....com.tw wrote:
>> >On Mon, Sep 23, 2024 at 05:48:28PM GMT, Hermes Wu wrote:
>> >> From: Hermes Wu <Hermes.wu@....com.tw>
>> >> 
>> >> Changes in v3:
>> >>  -add detials about fail item and changes.
>> >> 
>> >> 
>> >> Fix HDCP CTS fail items on UNIGRAF DRP-100
>> >> 
>> >> DUT must Support 127 devices.
>> >> DUT must check BSTATUS when receive CP_IRQ.
>> >> DUT must enable encryption when R0' is ready.
>> >> DUT must retry V' check 3 times.
>> >> it6505 must read DRP-100 KSV FIFO by FIFO mode.
>> >> it6505 should restart HDCP within 5s if KSV not ready.
>> >
>> >Still not readable.
>> >
>> >English text, please. Split the patch to fix one issue at a time.
>> >Describe the _reason_ for the change. Annotate fixes with Fixes tags.
>> >
>> 
>> with fixes tag include drm/bridge like this ?  => "Fixes: drm/bridge: it6505: HDCP CTS fail 1B-xx"
>
>No. Please read the document that I have been pointing you to. It describes all the tags and procedures.
>
>> 
>> About the reason about bug fixes. 
>> 
>> for example, the 1B-01 device count.
>> will this readable?
>> 
>> " When connect to HDCP repeater, it6505 must support 127 downstream devices. "
>> 
>> And this will be only one change in a patch?
>
>Let me repeat the phrase that you have quoted few lines above. "Split the patch to fix one issue at a time." So, no, this will not be the only change in the patch.
>

The HDCP CTS include serval items, I should split each failure item fixes into different patch?


>> 
>> >> 
>> >> Signed-off-by: Hermes Wu <Hermes.wu@....com.tw>
>> >> ---
>> >>  drivers/gpu/drm/bridge/ite-it6505.c | 112 
>> >> ++++++++++++++++++----------
>> >>  1 file changed, 74 insertions(+), 38 deletions(-)
>> >
>> >--
>> >With best wishes
>> >Dmitry
>> 
>> BR,
>> Hermes
>
>--
>With best wishes
>Dmitry