linux-kernel - Re: [RFC v3 2/2] usb: typec: tcpm: Add support for parsing time dt properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvK2slBHR8PhzaMt@kuha.fi.intel.com>
Date: Tue, 24 Sep 2024 15:55:14 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Amit Sunil Dhamne <amitsd@...gle.com>
Cc: gregkh@...uxfoundation.org, robh@...nel.org,
	dmitry.baryshkov@...aro.org, badhri@...gle.com, kyletso@...gle.com,
	rdbabiera@...gle.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [RFC v3 2/2] usb: typec: tcpm: Add support for parsing time dt
 properties

Hi,

> @@ -7611,10 +7650,13 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)
>  	err = tcpm_fw_get_caps(port, tcpc->fwnode);
>  	if (err < 0)
>  		goto out_destroy_wq;
> +


This extra newline is not relevant or necessary. Otherwise this LGTM:

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

>  	err = tcpm_fw_get_snk_vdos(port, tcpc->fwnode);
>  	if (err < 0)
>  		goto out_destroy_wq;
>  
> +	tcpm_fw_get_timings(port, tcpc->fwnode);
> +
>  	port->try_role = port->typec_caps.prefer_role;
>  
>  	port->typec_caps.revision = 0x0120;	/* Type-C spec release 1.2 */

thanks,

-- 
heikki