[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d95d7419-7bac-802f-a5d6-456900539c32@redhat.com>
Date: Tue, 24 Sep 2024 15:23:08 +0200 (CEST)
From: Mikulas Patocka <mpatocka@...hat.com>
To: Shen Lichuan <shenlichuan@...o.com>
cc: colyli@...e.de, kent.overstreet@...ux.dev, agk@...hat.com,
snitzer@...nel.org, song@...nel.org, yukuai3@...wei.com,
linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org,
dm-devel@...ts.linux.dev, linux-raid@...r.kernel.org
Subject: Re: [PATCH v1] md: Correct typos in multiple comments across various
files
Hi
I've applied the device mapper part of the patch.
Mikulas
On Tue, 24 Sep 2024, Shen Lichuan wrote:
> Fixed some confusing spelling errors that were currently identified,
> the details are as follows:
>
> -in the code comments:
> writeback.c: 124: overrite ==> overwrite
> dm-cache-target.c: 1371: exclussive ==> exclusive
> dm-raid.c: 2522: repective ==> respective
> md-cluster.c: 552: daemaon ==> daemon
> md.c: 511: entred ==> entered
> raid5-ppl.c: 990: parial ==> partial
>
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
> drivers/md/bcache/writeback.c | 2 +-
> drivers/md/dm-cache-target.c | 2 +-
> drivers/md/dm-raid.c | 2 +-
> drivers/md/md-cluster.c | 2 +-
> drivers/md/md.c | 2 +-
> drivers/md/raid5-ppl.c | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
> index c1d28e365910..3354a5cd587c 100644
> --- a/drivers/md/bcache/writeback.c
> +++ b/drivers/md/bcache/writeback.c
> @@ -121,7 +121,7 @@ static void __update_writeback_rate(struct cached_dev *dc)
> }
> fps = div_s64(dirty, dirty_buckets) * fp_term;
> if (fragment > 3 && fps > proportional_scaled) {
> - /* Only overrite the p when fragment > 3 */
> + /* Only overwrite the p when fragment > 3 */
> proportional_scaled = fps;
> }
> }
> diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
> index 17f0fab1e254..3e8be29c0a5e 100644
> --- a/drivers/md/dm-cache-target.c
> +++ b/drivers/md/dm-cache-target.c
> @@ -1368,7 +1368,7 @@ static void mg_copy(struct work_struct *ws)
> */
> bool rb = bio_detain_shared(mg->cache, mg->op->oblock, mg->overwrite_bio);
>
> - BUG_ON(rb); /* An exclussive lock must _not_ be held for this block */
> + BUG_ON(rb); /* An exclusive lock must _not_ be held for this block */
> mg->overwrite_bio = NULL;
> inc_io_migrations(mg->cache);
> mg_full_copy(ws);
> diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
> index 63682d27fc8d..1e0d3b9b75d6 100644
> --- a/drivers/md/dm-raid.c
> +++ b/drivers/md/dm-raid.c
> @@ -2519,7 +2519,7 @@ static int super_validate(struct raid_set *rs, struct md_rdev *rdev)
> rdev->saved_raid_disk = rdev->raid_disk;
> }
>
> - /* Reshape support -> restore repective data offsets */
> + /* Reshape support -> restore respective data offsets */
> rdev->data_offset = le64_to_cpu(sb->data_offset);
> rdev->new_data_offset = le64_to_cpu(sb->new_data_offset);
>
> diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
> index 6595f89becdb..867af995b767 100644
> --- a/drivers/md/md-cluster.c
> +++ b/drivers/md/md-cluster.c
> @@ -549,7 +549,7 @@ static void process_metadata_update(struct mddev *mddev, struct cluster_msg *msg
>
> dlm_lock_sync(cinfo->no_new_dev_lockres, DLM_LOCK_CR);
>
> - /* daemaon thread must exist */
> + /* daemon thread must exist */
> thread = rcu_dereference_protected(mddev->thread, true);
> wait_event(thread->wqueue,
> (got_lock = mddev_trylock(mddev)) ||
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 179ee4afe937..11078a4e4951 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -508,7 +508,7 @@ static void __mddev_resume(struct mddev *mddev, bool recovery_needed)
> return;
> }
>
> - /* entred the memalloc scope from mddev_suspend() */
> + /* entered the memalloc scope from mddev_suspend() */
> memalloc_noio_restore(mddev->noio_flag);
>
> percpu_ref_resurrect(&mddev->active_io);
> diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
> index a70cbec12ed0..5323025e7dd9 100644
> --- a/drivers/md/raid5-ppl.c
> +++ b/drivers/md/raid5-ppl.c
> @@ -987,7 +987,7 @@ static int ppl_recover(struct ppl_log *log, struct ppl_header *pplhdr,
> crc = ~0;
> crc_stored = le32_to_cpu(e->checksum);
>
> - /* read parial parity for this entry and calculate its checksum */
> + /* read partial parity for this entry and calculate its checksum */
> while (pp_size) {
> int s = pp_size > PAGE_SIZE ? PAGE_SIZE : pp_size;
>
> --
> 2.17.1
>
Powered by blists - more mailing lists