linux-kernel - Re: [PATCH] hwmon: (max6639) : Add DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0aaed899-9001-4355-bcca-17855576a928@roeck-us.net>
Date: Tue, 24 Sep 2024 07:12:46 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Naresh Solanki <naresh.solanki@...ements.com>
Cc: Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] hwmon: (max6639) : Add DT support

On 9/24/24 02:29, Naresh Solanki wrote:
> Hi Guenter,
> 
> Sorry for the late reply,
> 
> On Fri, 28 Jun 2024 at 20:30, Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> On 6/28/24 04:54, Naresh Solanki wrote:
>>> Remove platform data & add devicetree support.
>>>
>>
>> Unless I am missing something, this doesn't just add devicetree support,
>> it actually _mandates_ devicetree support. There are no defaults.
>> That is not acceptable.
> I agree with you. It is best to have some defaults & then overwrite
> based on DT properties.
> But in that case we would have to assume that all fans are enabled
> irrespective of their hardware connections in the schematics(example
> fan_enable).
> 
> I'm not sure if that is fine. But if you feel that is alright then
> I'll rewrite the driver to assume
> everything is enabled with default values.

That would still be a functional change, or am I missing something ?
It would overwrite any configuration written by a BIOS/ROMMON.

Guenter