| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <363a9d4d002e699ca1a1cd755ad41756ba1e72ba.camel@linux.intel.com>
Date: Tue, 24 Sep 2024 07:30:12 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Yan Zhen <yanzhen@...o.com>, jikos@...nel.org, bentiss@...nel.org,
bonbons@...ux-vserver.org, jic23@...nel.org
Cc: lains@...eup.net, hadess@...ess.net, linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
linux-usb@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] HID: Fix typo in the comment
On Tue, 2024-09-24 at 19:50 +0800, Yan Zhen wrote:
> Correctly spelled comments make it easier for the reader to
> understand
> the code.
>
> Fix typos:
> 'mninum' -> 'minimum',
> 'destoyed' -> 'destroyed',
> 'thridparty' -> 'thirdparty',
> 'lowcase' -> 'lowercase',
> 'idenitifiers' -> 'identifiers',
> 'exeuction' -> 'execution',
> 'fregments' -> 'fragments',
> 'devides' -> 'devices'.
>
> Signed-off-by: Yan Zhen <yanzhen@...o.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> ---
> drivers/hid/hid-asus.c | 2 +-
> drivers/hid/hid-logitech-hidpp.c | 2 +-
> drivers/hid/hid-picolcd_fb.c | 2 +-
> drivers/hid/hid-sensor-custom.c | 2 +-
> drivers/hid/hid-steam.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp/client.c | 2 +-
> drivers/hid/usbhid/hid-core.c | 2 +-
> 8 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index a4b47319ad8e..506c6f377e7d 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -1183,7 +1183,7 @@ static const __u8 *asus_report_fixup(struct
> hid_device *hdev, __u8 *rdesc,
>
> if (drvdata->quirks & QUIRK_G752_KEYBOARD &&
> *rsize == 75 && rdesc[61] == 0x15 && rdesc[62] ==
> 0x00) {
> - /* report is missing usage mninum and maximum */
> + /* report is missing usage minimum and maximum */
> __u8 *new_rdesc;
> size_t new_size = *rsize +
> sizeof(asus_g752_fixed_rdesc);
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 0e33fa0eb8db..d6d066c89c0b 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -2522,7 +2522,7 @@ static void hidpp_ff_work_handler(struct
> work_struct *w)
> /* regular effect destroyed */
> data->effect_ids[wd->params[0]-1] = -1;
> else if (wd->effect_id >=
> HIDPP_FF_EFFECTID_AUTOCENTER)
> - /* autocenter spring destoyed */
> + /* autocenter spring destroyed */
> data->slot_autocenter = 0;
> break;
> case HIDPP_FF_SET_GLOBAL_GAINS:
> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-
> picolcd_fb.c
> index 83e3409d170c..f8b16a82faef 100644
> --- a/drivers/hid/hid-picolcd_fb.c
> +++ b/drivers/hid/hid-picolcd_fb.c
> @@ -296,7 +296,7 @@ static void picolcd_fb_destroy(struct fb_info
> *info)
> /* make sure no work is deferred */
> fb_deferred_io_cleanup(info);
>
> - /* No thridparty should ever unregister our framebuffer! */
> + /* No thirdparty should ever unregister our framebuffer! */
> WARN_ON(fbdata->picolcd != NULL);
>
> vfree((u8 *)info->fix.smem_start);
> diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> sensor-custom.c
> index 66f0675df24b..617ae240396d 100644
> --- a/drivers/hid/hid-sensor-custom.c
> +++ b/drivers/hid/hid-sensor-custom.c
> @@ -946,7 +946,7 @@ hid_sensor_register_platform_device(struct
> platform_device *pdev,
>
> memcpy(real_usage, match->luid, 4);
>
> - /* usage id are all lowcase */
> + /* usage id are all lowercase */
> for (c = real_usage; *c != '\0'; c++)
> *c = tolower(*c);
>
> diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c
> index bf8b633114be..6439913372a8 100644
> --- a/drivers/hid/hid-steam.c
> +++ b/drivers/hid/hid-steam.c
> @@ -253,7 +253,7 @@ enum
> ID_CONTROLLER_DECK_STATE = 9
> };
>
> -/* String attribute idenitifiers */
> +/* String attribute identifiers */
> enum {
> ATTRIB_STR_BOARD_SERIAL,
> ATTRIB_STR_UNIT_SERIAL,
> diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> index e157863a8b25..750bfdd26ddb 100644
> --- a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> +++ b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> @@ -793,7 +793,7 @@ static int load_fw_from_host(struct ishtp_cl_data
> *client_data)
> if (rv < 0)
> goto end_err_fw_release;
>
> - /* Step 3: Start ISH main firmware exeuction */
> + /* Step 3: Start ISH main firmware execution */
>
> rv = ish_fw_start(client_data);
> if (rv < 0)
> diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c
> b/drivers/hid/intel-ish-hid/ishtp/client.c
> index 8a7f2f6a4f86..e61b01e9902e 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/client.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/client.c
> @@ -863,7 +863,7 @@ static void ipc_tx_send(void *prm)
> /* Send ipc fragment */
> ishtp_hdr.length = dev->mtu;
> ishtp_hdr.msg_complete = 0;
> - /* All fregments submitted to IPC queue with
> no callback */
> + /* All fragments submitted to IPC queue with
> no callback */
> ishtp_write_message(dev, &ishtp_hdr, pmsg);
> cl->tx_offs += dev->mtu;
> rem = cl_msg->send_buf.size - cl->tx_offs;
> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-
> core.c
> index cb687ea7325c..956b86737b07 100644
> --- a/drivers/hid/usbhid/hid-core.c
> +++ b/drivers/hid/usbhid/hid-core.c
> @@ -1100,7 +1100,7 @@ static int usbhid_start(struct hid_device *hid)
>
> interval = endpoint->bInterval;
>
> - /* Some vendors give fullspeed interval on highspeed
> devides */
> + /* Some vendors give fullspeed interval on highspeed
> devices */
> if (hid->quirks & HID_QUIRK_FULLSPEED_INTERVAL &&
> dev->speed == USB_SPEED_HIGH) {
> interval = fls(endpoint->bInterval*8);
Powered by blists - more mailing lists