linux-kernel - Re: [PATCH v1 2/3] arm64: dts: freescale: imx8mp-verdin: add labels to som nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvLUmqM5FWqKPxoi@lizhi-Precision-Tower-5810>
Date: Tue, 24 Sep 2024 11:02:50 -0400
From: Frank Li <Frank.li@....com>
To: Francesco Dolcini <francesco@...cini.it>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	João Paulo Gonçalves <joao.goncalves@...adex.com>,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Francesco Dolcini <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v1 2/3] arm64: dts: freescale: imx8mp-verdin: add labels
 to som nodes

On Tue, Sep 24, 2024 at 01:40:52PM +0200, Francesco Dolcini wrote:
> From: João Paulo Gonçalves <joao.goncalves@...adex.com>
>
> Add labels to ti-ads1015 and fec ethernet mdio node to make it easier to
> reference them from other nodes.
>
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@...adex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index a19ad5ee7f79..e9518b7c7aa8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -320,7 +320,7 @@ &fec {
>  	pinctrl-0 = <&pinctrl_fec>;
>  	pinctrl-1 = <&pinctrl_fec_sleep>;
>
> -	mdio {
> +	verdin_eth2_mdio: mdio {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>
> @@ -591,11 +591,12 @@ hwmon_temp_module: sensor@48 {
>  		vs-supply = <&reg_vdd_1v8>;
>  	};
>
> -	adc@49 {
> +	verdin_som_adc: adc@49 {
>  		compatible = "ti,ads1015";
>  		reg = <0x49>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +		#io-channel-cells = <1>;

Why add this? it is not related with what descript in commit message

Frank

>
>  		/* Verdin I2C_1 (ADC_4 - ADC_3) */
>  		channel@0 {
> --
> 2.39.5
>