linux-kernel - Re: [PATCH v2 07/10] iio: adc: ad7606: Add compatibility to fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMknhBGOn_vhvHJU8g89A2TDmA6yFv9urpZ4A96jOMLdTtR-Bw@mail.gmail.com>
Date: Tue, 24 Sep 2024 17:28:38 +0200
From: David Lechner <dlechner@...libre.com>
To: Guillaume Stols <gstols@...libre.com>
Cc: Uwe Kleine-König <ukleinek@...nel.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
	Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Jonathan Corbet <corbet@....net>, Michal Marek <mmarek@...e.com>, linux-pwm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org, 
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-doc@...r.kernel.org, aardelean@...libre.com, jstephan@...libre.com
Subject: Re: [PATCH v2 07/10] iio: adc: ad7606: Add compatibility to fw_nodes

On Fri, Sep 20, 2024 at 7:33 PM Guillaume Stols <gstols@...libre.com> wrote:
>
> On the parallel version, the current implementation is only compatible
> with id tables and won't work with fw_nodes, this commit intends to fix
> it.
>
> Also, chip info is moved in the .h file so to be accessible to all the
> driver files that can set a pointer to the corresponding chip as the
> driver data.

This sounds like two unrelated changes, so maybe we should have two patches?


>  static const struct of_device_id ad7606_of_match[] = {
> -       { .compatible = "adi,ad7605-4" },
> -       { .compatible = "adi,ad7606-4" },
> -       { .compatible = "adi,ad7606-6" },
> -       { .compatible = "adi,ad7606-8" },
> -       { .compatible = "adi,ad7606b" },
> -       { .compatible = "adi,ad7616" },
> +       { .compatible = "adi,ad7605-4", &ad7605_4_info },
> +       { .compatible = "adi,ad7606-4", &ad7606_4_info },
> +       { .compatible = "adi,ad7606-6", &ad7606_6_info },
> +       { .compatible = "adi,ad7606-8", &ad7606_8_info },
> +       { .compatible = "adi,ad7606b", &ad7606b_info },
> +       { .compatible = "adi,ad7616", &ad7616_info },

Since we have .compatible = , we should also have .data = for the chip info.