linux-kernel - Re: [PATCH] hwmon: (max6639) : Add DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84ba0d7f-cb85-4f00-a8a9-ad8e8a56840f@roeck-us.net>
Date: Tue, 24 Sep 2024 08:43:23 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Naresh Solanki <naresh.solanki@...ements.com>
Cc: Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] hwmon: (max6639) : Add DT support

On 9/24/24 07:44, Naresh Solanki wrote:
> Hi Guenter,
> 
> On Tue, 24 Sept 2024 at 19:42, Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> On 9/24/24 02:29, Naresh Solanki wrote:
>>> Hi Guenter,
>>>
>>> Sorry for the late reply,
>>>
>>> On Fri, 28 Jun 2024 at 20:30, Guenter Roeck <linux@...ck-us.net> wrote:
>>>>
>>>> On 6/28/24 04:54, Naresh Solanki wrote:
>>>>> Remove platform data & add devicetree support.
>>>>>
>>>>
>>>> Unless I am missing something, this doesn't just add devicetree support,
>>>> it actually _mandates_ devicetree support. There are no defaults.
>>>> That is not acceptable.
>>> I agree with you. It is best to have some defaults & then overwrite
>>> based on DT properties.
>>> But in that case we would have to assume that all fans are enabled
>>> irrespective of their hardware connections in the schematics(example
>>> fan_enable).
>>>
>>> I'm not sure if that is fine. But if you feel that is alright then
>>> I'll rewrite the driver to assume
>>> everything is enabled with default values.
>>
>> That would still be a functional change, or am I missing something ?
>> It would overwrite any configuration written by a BIOS/ROMMON.
> With that, driver would take the current chip configuration as default &
> just configure specific config specified in DT(if any) & continue with
> initialization?

Yes.

Thanks,
Guenter