linux-kernel - Re: [PATCH 6/7] iio: adc: ad485x: add ad485x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202409242353.rDAcuGYR-lkp@intel.com>
Date: Wed, 25 Sep 2024 00:08:29 +0800
From: kernel test robot <lkp@...el.com>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Nuno Sa <nuno.sa@...log.com>,
	Olivier Moysan <olivier.moysan@...s.st.com>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	Andy Shevchenko <andy@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Marcelo Schmitt <marcelo.schmitt@...log.com>,
	João Paulo Gonçalves <joao.goncalves@...adex.com>,
	Mike Looijmans <mike.looijmans@...ic.nl>,
	Dumitru Ceclan <mitrutzceclan@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Alisa-Dariana Roman <alisadariana@...il.com>,
	Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
	Dragos Bogdan <dragos.bogdan@...log.com>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-pwm@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH 6/7] iio: adc: ad485x: add ad485x driver

Hi Antoniu,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.11]
[cannot apply to jic23-iio/togreg next-20240924]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Antoniu-Miclaus/iio-backend-add-API-for-interface-get/20240923-182050
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20240923101206.3753-7-antoniu.miclaus%40analog.com
patch subject: [PATCH 6/7] iio: adc: ad485x: add ad485x driver
config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20240924/202409242353.rDAcuGYR-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240924/202409242353.rDAcuGYR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409242353.rDAcuGYR-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/iio/adc/ad485x.c: In function 'ad485x_get_packet_format':
>> drivers/iio/adc/ad485x.c:396:18: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
     396 |         format = FIELD_GET(AD485X_PACKET_FORMAT_MASK, format);
         |                  ^~~~~~~~~
   drivers/iio/adc/ad485x.c: At top level:
   drivers/iio/adc/ad485x.c:854:23: warning: initialized field overwritten [-Woverride-init]
     854 |         .resolution = 16,
         |                       ^~
   drivers/iio/adc/ad485x.c:854:23: note: (near initialization for 'ad4856_info.resolution')


vim +/FIELD_GET +396 drivers/iio/adc/ad485x.c

   384	
   385	static int ad485x_get_packet_format(struct iio_dev *indio_dev,
   386					    const struct iio_chan_spec *chan)
   387	{
   388		struct ad485x_state *st = iio_priv(indio_dev);
   389		unsigned int format;
   390		int ret;
   391	
   392		ret = regmap_read(st->regmap, AD485X_REG_PACKET, &format);
   393		if (ret)
   394			return ret;
   395	
 > 396		format = FIELD_GET(AD485X_PACKET_FORMAT_MASK, format);
   397	
   398		return format;
   399	}
   400	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki