linux-kernel - Re: [PATCH] soc: ti: knav_qmss_queue: remove useless statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb73ec97-dcf7-41ac-ae88-20611fcff72b@linuxfoundation.org>
Date: Tue, 24 Sep 2024 10:20:23 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Alessandro Zanni <alessandro.zanni87@...il.com>, nm@...com,
 ssantosh@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 anupnewsmail@...il.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] soc: ti: knav_qmss_queue: remove useless statement

On 9/24/24 07:20, Alessandro Zanni wrote:
> Remove the statement "continue" at the end of the loop where it
> becomes useless.

How did you find the problem? Change log should say how you found
it.

> 
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@...il.com>
> ---
>   drivers/soc/ti/knav_qmss_queue.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index 6c98738e548a..1cc54905b398 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -723,7 +723,6 @@ static void kdesc_empty_pool(struct knav_pool *pool)
>   		if (!desc) {
>   			dev_dbg(pool->kdev->dev,
>   				"couldn't unmap desc, continuing\n");
> -			continue;
>   		}
>   	}
>   	WARN_ON(i != pool->num_desc);

thanks,
-- Shuah