linux-kernel - Re: [patch v2 3/3] riscv: dts: starfive: add framework dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240924-ended-tactics-b2e779875a76@spud>
Date: Tue, 24 Sep 2024 17:26:18 +0100
From: Conor Dooley <conor@...nel.org>
To: Rafał Miłecki <rafal@...ecki.pl>
Cc: Sandie Cao <sandie.cao@...pcomputing.io>,
	Emil Renner Berthing <kernel@...il.dk>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Heiko Stuebner <heiko.stuebner@...rry.de>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Michael Zhu <michael.zhu@...rfivetech.com>,
	Drew Fustini <drew@...gleboard.org>,
	linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, dhs@...me.work, ams@...me.work,
	gregkh@...uxfoundation.org, yuning.liang@...pcomputing.io,
	huiming.qiu@...pcomputing.io
Subject: Re: [patch v2 3/3] riscv: dts: starfive: add framework dts

On Tue, Sep 24, 2024 at 11:55:44AM +0200, Rafał Miłecki wrote:
> On 2024-09-24 10:06, Sandie Cao wrote:
> > diff --git a/arch/riscv/boot/dts/starfive/jh7110-framework.dts
> > b/arch/riscv/boot/dts/starfive/jh7110-framework.dts
> > new file mode 100644
> > index 000000000000..ff12c24ebab3
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/starfive/jh7110-framework.dts
> > @@ -0,0 +1,34 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR MIT
> > +/*
> > + * Copyright (C) 2022 StarFive Technology Co., Ltd.
> > + * Copyright (C) 2022 Emil Renner Berthing <kernel@...il.dk>
> > + */
> > +
> > +/dts-v1/;
> > +#include "jh7110-common.dtsi"
> > +
> > +/ {
> > +	model = "Framework FRANME0000";
> > +	compatible = "deepcomputing,fm7110", "starfive,jh7110";
> > +};
> 
> Nitpicking: property "compatible" should go first.
> 
> See Documentation/devicetree/bindings/dts-coding-style.rst

I think "model" usually goes before compatible, I wouldn't change it
here.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)