linux-kernel - [PATCH -next 1/2] kobject: fix memory leak in kset_register() due to uninitialized kset->kobj.ktype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240925120747.1930709-2-cuigaosheng1@huawei.com>
Date: Wed, 25 Sep 2024 20:07:46 +0800
From: Gaosheng Cui <cuigaosheng1@...wei.com>
To: <gregkh@...uxfoundation.org>, <rafael@...nel.org>,
	<akpm@...ux-foundation.org>, <thunder.leizhen@...wei.com>,
	<cuigaosheng1@...wei.com>, <wangweiyang2@...wei.com>
CC: <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: [PATCH -next 1/2] kobject: fix memory leak in kset_register() due to uninitialized kset->kobj.ktype

If a kset with uninitialized kset->kobj.ktype be registered,
kset_register() will return error, and the kset.kobj.name allocated
by kobject_set_name() will be leaked.

To mitigate this, we free the name in kset_register() when an error
is encountered due to uninitialized kset->kobj.ktype.

Fixes: 4d0fe8c52bb3 ("kobject: Add sanity check for kset->kobj.ktype in kset_register()")
Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
---
 lib/kobject.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/kobject.c b/lib/kobject.c
index 72fa20f405f1..ecca72622933 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -862,6 +862,8 @@ int kset_register(struct kset *k)
 		return -EINVAL;
 
 	if (!k->kobj.ktype) {
+		kfree_const(k->kobj.name);
+		k->kobj.name = NULL;
 		pr_err("must have a ktype to be initialized properly!\n");
 		return -EINVAL;
 	}
-- 
2.25.1