linux-kernel - Re: [RFC v3 2/2] usb: typec: tcpm: Add support for parsing time dt properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d72cc89a-7f73-4294-927e-48e647e37310@google.com>
Date: Tue, 24 Sep 2024 19:44:19 -0700
From: Amit Sunil Dhamne <amitsd@...gle.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: gregkh@...uxfoundation.org, robh@...nel.org, dmitry.baryshkov@...aro.org,
 badhri@...gle.com, kyletso@...gle.com, rdbabiera@...gle.com,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [RFC v3 2/2] usb: typec: tcpm: Add support for parsing time dt
 properties

Hi Heikki,

On 9/24/24 5:55 AM, Heikki Krogerus wrote:
> Hi,
>
>> @@ -7611,10 +7650,13 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)
>>   	err = tcpm_fw_get_caps(port, tcpc->fwnode);
>>   	if (err < 0)
>>   		goto out_destroy_wq;
>> +
>
> This extra newline is not relevant or necessary. Otherwise this LGTM:

Thanks for reviewing! Please let me know if I should upload a new set or 
this is alright at this time?

--

Amit

>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>
>>   	err = tcpm_fw_get_snk_vdos(port, tcpc->fwnode);
>>   	if (err < 0)
>>   		goto out_destroy_wq;
>>   
>> +	tcpm_fw_get_timings(port, tcpc->fwnode);
>> +
>>   	port->try_role = port->typec_caps.prefer_role;
>>   
>>   	port->typec_caps.revision = 0x0120;	/* Type-C spec release 1.2 */
> thanks,
>