linux-kernel - Re: [PATCH v1 0/5] i2c: designware: Cleanups (part 4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8d7ceb6-6027-4879-b6e0-32f2299d2e54@linux.intel.com>
Date: Wed, 25 Sep 2024 16:37:20 +0300
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Mario Limonciello <mario.limonciello@....com>,
 Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Philipp Zabel <p.zabel@...gutronix.de>,
 Narasimhan.V@....com, Borislav Petkov <bp@...en8.de>,
 Kim Phillips <kim.phillips@....com>
Subject: Re: [PATCH v1 0/5] i2c: designware: Cleanups (part 4)

On 9/25/24 3:44 PM, Andy Shevchenko wrote:
> This is the subset of the patches [1] that should not affect any
> functionality. Here are:
> - tiding up the probe and remove functions
> - dead and redundant code removal
> - spelling fixes
> 
> In any case this is Cc'ed to AMD who reported a problem in [1]
> presumably in the patch that is *not* included here.
> 
> Link: https://lore.kernel.org/linux-i2c/20231207141653.2785124-1-andriy.shevchenko@linux.intel.com/ [1]
> 
> This is assumed to be the last straightforward patch series to clean up
> the driver. The rest is directly related or dependent on the reported
> problem and needs more thinking and work. Perhaps I can do it in the
> future.
> 
> Andy Shevchenko (5):
>    i2c: designware: Use temporary variable for struct device
>    i2c: designware: Get rid of redundant 'else'
>    i2c: designware: Remove 'cond' from i2c_dw_scl_hcnt()
>    i2c: designware: Use sda_hold_time variable name everywhere
>    i2c: designware: Fix spelling and other issues in the comments
> 
>   drivers/i2c/busses/i2c-designware-amdpsp.c  | 10 ++--
>   drivers/i2c/busses/i2c-designware-common.c  | 66 +++++++--------------
>   drivers/i2c/busses/i2c-designware-core.h    | 12 ++--
>   drivers/i2c/busses/i2c-designware-master.c  | 17 +++---
>   drivers/i2c/busses/i2c-designware-pcidrv.c  | 39 ++++++------
>   drivers/i2c/busses/i2c-designware-platdrv.c | 52 ++++++++--------
>   drivers/i2c/busses/i2c-designware-slave.c   |  6 +-
>   7 files changed, 90 insertions(+), 112 deletions(-)
> 
To all:

Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>