linux-kernel - [PATCH linux-next] usb: typec: tcpm: use max() to get higher value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240925122014.552221-1-prosunofficial@gmail.com>
Date: Wed, 25 Sep 2024 17:50:14 +0530
From: R Sundar <prosunofficial@...il.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	RD Babiera <rdbabiera@...gle.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Badhri Jagan Sridharan <badhri@...gle.com>,
	Kyle Tso <kyletso@...gle.com>,
	Xu Yang <xu.yang_2@....com>
Cc: linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	frank.wang@...k-chips.com,
	R Sundar <prosunofficial@...il.com>,
	kernel test robot <lkp@...el.com>,
	Julia Lawall <julia.lawall@...ia.fr>
Subject: [PATCH linux-next] usb: typec: tcpm: use max() to get higher value

Use max() for better readability and to fix cocci warnings.

Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Julia Lawall <julia.lawall@...ia.fr>
Closes: https://lore.kernel.org/r/202409231009.2efXAh9b-lkp@intel.com/
Signed-off-by: R Sundar <prosunofficial@...il.com>
---

Reported in linux repo.
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

cocci warnings: (new ones prefixed by >>)
>> drivers/usb/typec/tcpm/tcpm.c:6356:20-21: WARNING opportunity for max()

vim +6356 drivers/usb/typec/tcpm/tcpm.c

compile-tested only.

 drivers/usb/typec/tcpm/tcpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index fc619478200f..aac4de1d53a8 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -7367,7 +7367,7 @@ static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
 			src_mv = pdo_fixed_voltage(pdo);
 			src_ma = pdo_max_current(pdo);
 			tmp = src_mv * src_ma;
-			max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
+			max_src_uw = max(tmp, max_src_uw);
 		}
 	}
 
-- 
2.34.1