linux-kernel - Re: [PATCH -next 2/3] drm/tegra: Enable module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <n3ydihjvwboq2dlby7sknpccbah6jape4c3y7gvuyt72yb4ame@xvejzzaxtyqe>
Date: Wed, 25 Sep 2024 15:45:01 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Liao Chen <liaochen4@...wei.com>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org, andrzej.hajda@...el.com, 
	neil.armstrong@...aro.org, rfoss@...nel.org, Laurent.pinchart@...asonboard.com, 
	jonas@...boo.se, jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com, 
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch, 
	linus.walleij@...aro.org, mperttunen@...dia.com, jonathanh@...dia.com
Subject: Re: [PATCH -next 2/3] drm/tegra: Enable module autoloading

On Mon, Sep 23, 2024 at 07:21:21AM GMT, Dmitry Baryshkov wrote:
> On Mon, Sep 02, 2024 at 11:33:19AM GMT, Liao Chen wrote:
> > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> > on the alias from of_device_id table.
> > 
> > Signed-off-by: Liao Chen <liaochen4@...wei.com>
> > ---
> >  drivers/gpu/drm/tegra/drm.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
> > index 03d1c76aec2d..1a12f2eaad86 100644
> > --- a/drivers/gpu/drm/tegra/drm.c
> > +++ b/drivers/gpu/drm/tegra/drm.c
> > @@ -1390,6 +1390,7 @@ static const struct of_device_id host1x_drm_subdevs[] = {
> >  	{ .compatible = "nvidia,tegra234-nvdec", },
> >  	{ /* sentinel */ }
> >  };
> > +MODULE_DEVICE_TABLE(of, host1x_drm_subdevs);
> 
> I don't think it is correct. See how subdevs are handled in
> host1x_device_parse_dt(). I'll pick up two other patches though.

Agreed. This shouldn't be needed since all of these compatible strings
should show up in the OF device ID table of their corresponding drivers,
which is where the export should happen.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)