linux-kernel - Re: [PATCH v3 3/3] riscv: dts: starfive: add framework dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172727480703.1213985.11388868881210687280.robh@kernel.org>
Date: Wed, 25 Sep 2024 09:36:41 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Sandie Cao <sandie.cao@...pcomputing.io>
Cc: yuning.liang@...pcomputing.io, Conor Dooley <conor@...nel.org>, 
 Albert Ou <aou@...s.berkeley.edu>, linux-kernel@...r.kernel.org, 
 Linus Walleij <linus.walleij@...aro.org>, 
 Drew Fustini <drew@...gleboard.org>, 
 Heiko Stuebner <heiko.stuebner@...rry.de>, gregkh@...uxfoundation.org, 
 Neil Armstrong <neil.armstrong@...aro.org>, rafal@...ecki.pl, 
 dhs@...me.work, linux-riscv@...ts.infradead.org, 
 Emil Renner Berthing <kernel@...il.dk>, devicetree@...r.kernel.org, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Michael Zhu <michael.zhu@...rfivetech.com>, 
 Palmer Dabbelt <palmer@...belt.com>, 
 Paul Walmsley <paul.walmsley@...ive.com>, huiming.qiu@...pcomputing.io, 
 ams@...me.work
Subject: Re: [PATCH v3 3/3] riscv: dts: starfive: add framework dts


On Wed, 25 Sep 2024 13:31:23 +0800, Sandie Cao wrote:
> Add framework dts to support RISC-V Framework Laptop 13 Mainboard.
> 
> 
> DeepComputing is creating a RISC-V Framework Laptop 13 Mainboard
> powered by a StarFive JH7110 processor.This is a developer-focused
> product, aimed at making tinkering with RISC-V more accessible.
> The Mainboard is under development and we'll share more on functionality,
> compatibility, and availability as the program progresses.
> 
> For this Mainboard, the Model name in Framework is Framework FRANME0000;
> the Model name in DeepComputing is DeepComputing fm7110.
> 
> The board features:
> 
> - JH7110 SoC
> - 8 GiB LPDDR4 DRAM
> - 1x Type-c(PD3.0:60W Max;usb3.2 Gen1;usb2.0;DP1.4:4K@...z/2.5K@...z)
> - 1x Type-c(PD3.0:60W Max,usb3.2 Gen1;usb2.0)
> - 2x Type-c(usb3.2 Gen1;usb2.0)
> - 1x eMMC slot Support 32G/128G
> - 1x MicroSD slot
> - 1x QSPI Flash
> - 1x PCIe Wi-Fi (Support AMD RZ616 Wi-Fi 6E,Intel Wi-Fi 6E AX210 No vPro)
> 
> Signed-off-by: Sandie Cao <sandie.cao@...pcomputing.io>
> ---
>  arch/riscv/boot/dts/starfive/Makefile         |  1 +
>  .../boot/dts/starfive/jh7110-framework.dts    | 34 +++++++++++++++++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 arch/riscv/boot/dts/starfive/jh7110-framework.dts
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y starfive/jh7110-framework.dtb' for 20240925053123.1364574-4-sandie.cao@...pcomputing.io:

arch/riscv/boot/dts/starfive/jh7110-framework.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed:
	'deepcomputing,fm7110' is not one of ['beagle,beaglev-starlight-jh7100-r0', 'starfive,visionfive-v1']
	'deepcomputing,fm7110' is not one of ['milkv,mars', 'pine64,star64', 'starfive,visionfive-2-v1.2a', 'starfive,visionfive-2-v1.3b']
	'starfive,jh7100' was expected
	from schema $id: http://devicetree.org/schemas/riscv/starfive.yaml#
arch/riscv/boot/dts/starfive/jh7110-framework.dtb: /: failed to match any schema with compatible: ['deepcomputing,fm7110', 'starfive,jh7110']