linux-kernel - [PATCH] tty: serial: fsl_lpuart: Use common code in lpuart_global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f1216028-ef38-4f05-996b-bafc71777abd@web.de>
Date: Wed, 25 Sep 2024 16:45:06 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-serial@...r.kernel.org,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Peng Fan <peng.fan@....com>,
 Sherry Sun <sherry.sun@....com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: [PATCH] tty: serial: fsl_lpuart: Use common code in
 lpuart_global_reset()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 25 Sep 2024 16:36:20 +0200

Add a label so that two statements can be better reused at the end of
this function implementation.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/tty/serial/fsl_lpuart.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 77efa7ee6eda..b63419c1a4ea 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2811,8 +2811,7 @@ static int lpuart_global_reset(struct lpuart_port *sport)
 					      port)) {
 				dev_warn(sport->port.dev,
 					 "timeout waiting for transmit engine to complete\n");
-				clk_disable_unprepare(sport->ipg_clk);
-				return 0;
+				goto disable_unprepare_clk;
 			}
 		}

@@ -2828,7 +2827,7 @@ static int lpuart_global_reset(struct lpuart_port *sport)
 			lpuart32_write(port, ctrl, UARTCTRL);
 		}
 	}
-
+disable_unprepare_clk:
 	clk_disable_unprepare(sport->ipg_clk);
 	return 0;
 }
--
2.46.1