linux-kernel - Re: [PATCH] Bluetooth: btusb: Add USB HW IDs for MT7920/MT7925

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABBYNZJQ4WVAgTPpQBsPp+wBqymN_inisdFZXoMT_b9YdXf2Jw@mail.gmail.com>
Date: Wed, 25 Sep 2024 11:03:13 -0400
From: Luiz Augusto von Dentz <luiz.dentz@...il.com>
To: Jiande Lu <jiande.lu@...iatek.com>
Cc: Marcel Holtmann <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>, 
	Sean Wang <sean.wang@...iatek.com>, Chris Lu <chris.lu@...iatek.com>, 
	Deren Wu <deren.Wu@...iatek.com>, Aaron Hou <aaron.hou@...iatek.com>, 
	Steve Lee <steve.lee@...iatek.com>, linux-bluetooth <linux-bluetooth@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	linux-mediatek <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] Bluetooth: btusb: Add USB HW IDs for MT7920/MT7925

Hi Jiande,

On Sun, Sep 15, 2024 at 11:22 PM Jiande Lu <jiande.lu@...iatek.com> wrote:
>
> Add HW IDs for wireless module. These HW IDs are extracted from
> Windows driver inf file and the test for card bring up successful.

Well this is not enough if we don't have firmware published for them,
or you have confirmed that firmware is available and it does load
properly? In that case please add the information about the firmware
as well and perhaps some logs that it can be loaded properly.

> Signed-off-by: Jiande Lu <jiande.lu@...iatek.com>
> ---
>  drivers/bluetooth/btusb.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 6c9c761d5b93..8946aafae640 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -563,6 +563,16 @@ static const struct usb_device_id quirks_table[] = {
>         { USB_DEVICE(0x043e, 0x3109), .driver_info = BTUSB_MEDIATEK |
>                                                      BTUSB_WIDEBAND_SPEECH },
>
> +       /* Additional MediaTek MT7920 Bluetooth devices */
> +       { USB_DEVICE(0x0489, 0xe134), .driver_info = BTUSB_MEDIATEK |
> +                                                    BTUSB_WIDEBAND_SPEECH },
> +       { USB_DEVICE(0x13d3, 0x3620), .driver_info = BTUSB_MEDIATEK |
> +                                                    BTUSB_WIDEBAND_SPEECH },
> +       { USB_DEVICE(0x13d3, 0x3621), .driver_info = BTUSB_MEDIATEK |
> +                                                    BTUSB_WIDEBAND_SPEECH },
> +       { USB_DEVICE(0x13d3, 0x3622), .driver_info = BTUSB_MEDIATEK |
> +                                                    BTUSB_WIDEBAND_SPEECH },
> +
>         /* Additional MediaTek MT7921 Bluetooth devices */
>         { USB_DEVICE(0x0489, 0xe0c8), .driver_info = BTUSB_MEDIATEK |
>                                                      BTUSB_WIDEBAND_SPEECH },
> @@ -636,6 +646,8 @@ static const struct usb_device_id quirks_table[] = {
>                                                      BTUSB_WIDEBAND_SPEECH },
>         { USB_DEVICE(0x0489, 0xe11e), .driver_info = BTUSB_MEDIATEK |
>                                                      BTUSB_WIDEBAND_SPEECH },
> +       { USB_DEVICE(0x0489, 0xe139), .driver_info = BTUSB_MEDIATEK |
> +                                                    BTUSB_WIDEBAND_SPEECH },
>         { USB_DEVICE(0x13d3, 0x3602), .driver_info = BTUSB_MEDIATEK |
>                                                      BTUSB_WIDEBAND_SPEECH },
>         { USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK |
> --
> 2.45.2
>


-- 
Luiz Augusto von Dentz