linux-kernel - Re: [PATCH v3 net] net: systemport: Add error pointer checks in bcm_sysport_map_queues() and bcm_sysport_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEKBCKN=J6esdjOF5yh1KtmOVTgmXpKjTfbXAzyRcULKzbMi9w@mail.gmail.com>
Date: Wed, 25 Sep 2024 21:22:48 +0545
From: Dipendra Khadka <kdipendra88@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	f.fainelli@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 net] net: systemport: Add error pointer checks in
 bcm_sysport_map_queues() and bcm_sysport_unmap_queues()

Hi Simon,

On Wed, 25 Sept 2024 at 17:04, Simon Horman <horms@...nel.org> wrote:
>
> On Tue, Sep 24, 2024 at 06:56:33PM +0000, Dipendra Khadka wrote:
> > Add error pointer checks in bcm_sysport_map_queues() and
> > bcm_sysport_unmap_queues() after calling dsa_port_from_netdev().
> >
> > Fixes: d156576362c0 ("net: systemport: Establish lower/upper queue mapping")
> > Fixes: da106a140f9c ("net: systemport: Unmap queues upon DSA unregister event")
> > Signed-off-by: Dipendra Khadka <kdipendra88@...il.com>
>
> I'm sorry to be picky, but I think the fixes tag should be (only):
>
> Fixes: 1593cd40d785 ("net: systemport: use standard netdevice notifier to detect DSA presence")
>



I have sent the v4 patch. I was checking git log -S 'function name
like bcm_sysport_map_queues'. But when I checked with the
"dsa_port_from_netdev", I got the same result as yours.Thank you once
again.

> Otherwise, this looks good to me.
>
> ...

Best regards,
Dipendra Khadka