linux-kernel - Re: [PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8bc57566-2867-49f5-8b66-7c5f32c1a0c8@gmail.com>
Date: Thu, 26 Sep 2024 00:25:25 +0800
From: Tao Chen <chen.dylane@...il.com>
To: Daniel Borkmann <daniel@...earbox.net>, patchwork-bot+netdevbpf@...nel.org
Cc: qmo@...nel.org, ast@...nel.org, andrii@...nel.org, martin.lau@...ux.dev,
 eddyz87@...il.com, song@...nel.org, yonghong.song@...ux.dev,
 jolsa@...nel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

在 2024/9/25 18:32, Daniel Borkmann 写道:
> On 9/25/24 11:50 AM, patchwork-bot+netdevbpf@...nel.org wrote:
>> Hello:
>>
>> This patch was applied to bpf/bpf-next.git (master)
>> by Daniel Borkmann <daniel@...earbox.net>:
>>
>> On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:
>>> As Quentin and Andrri said [0], bpftool gen object strips
>>> out DWARF already, so remove the repeat operation.
>>>
>>> [0] https://github.com/libbpf/bpftool/issues/161
>>>
>>> Suggested-by: Andrii Nakryiko <andrii@...nel.org>
>>> Suggested-by: Quentin Monnet <qmo@...nel.org>
>>> Signed-off-by: Tao Chen <chen.dylane@...il.com>
>>>
>>> [...]
> I'll toss this shortly from the tree again, this missed that bpftool gen 
> object call
> needs to strip out dwarf.

Hi Daniel, i saw linker_sanity_check_elf will ignore the dwarf sec, 
which means bpftool gen object will strip, is my understanding correct?

static int linker_sanity_check_elf(struct src_obj *obj)
{
	...
	if (is_dwarf_sec_name(sec->sec_name))
		continue;
	...
}
>>> Here is the summary with links:
>>>    - [bpf-next] bpftool: Remove llvm-strip from Makefile
>>>      https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32
>>>
>>> You are awesome, thank you!


-- 
Best Regards
Dylane Chen