linux-kernel - Question about num_possible_cpus() and cpu_possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SN6PR02MB4157210CC36B2593F8572E5ED4692@SN6PR02MB4157.namprd02.prod.outlook.com>
Date: Wed, 25 Sep 2024 04:04:33 +0000
From: Michael Kelley <mhklinux@...look.com>
To: Thomas Gleixner <tglx@...utronix.de>, "peterz@...radead.org"
	<peterz@...radead.org>, Borislav Petkov <bp@...en8.de>, Yury Norov
	<yury.norov@...il.com>
CC: "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Question about num_possible_cpus() and cpu_possible_mask

Question:  Is there any intention to guarantee that the cpu_possible_mask is
"dense", in that all bit positions 0 thru (nr_cpu_ids - 1) are set, with no
"holes"? If that were true, then num_possible_cpus() would be equal to
nr_cpu_ids.

x86 always sets up cpu_possible_mask as dense, as does ARM64 with ACPI.
But it appears there are errors cases on ARM64 with DeviceTree where this
is not the case. I haven't looked at other architectures.

There's evidence both ways:
1) A somewhat recent report[1] on SPARC where cpu_possible_mask
   isn't dense, and there's code assuming that it is dense. This report
   got me thinking about the question.

2) setup_nr_cpu_ids() in kernel/smp.c is coded to *not* assume it is dense

3) But there are several places throughout the kernel that do something like
   the following, which assumes they are dense:

	array = kcalloc(num_possible_cpus(), sizeof(<some struct>), GFP_KERNEL);
	....
	index into "array" with smp_processor_id()

On balance, I'm assuming that there's no requirement for cpu_possible_mask
to be dense, and code like #3 above is technically wrong. It should be
using nr_cpu_ids instead of num_possible_cpus(), which is also faster.
We get away with it 99.99% of the time because all (or almost all?)
architectures populate cpu_possible_mask as dense.

There are 6 places in Hyper-V specific code that do #3. And it works because
Hyper-V code only runs on x86 and ARM64 where cpu_possible_mask is
always dense. But in the interest of correctness and robustness against
future changes, I'm planning to fix the Hyper-V code.

There are also a few other places throughout the kernel with the same
problem, and I may look at fixing those as well.

Or maybe my assumptions are off-base. Any thoughts or guidance before
I start submitting patches?

Thanks,

Michael

[1] https://lore.kernel.org/lkml/20240621033005.6mccm7waduelb4m5@oppo.com/