linux-kernel - Re: [PATCH] ssb: Call ssb_bus_may_powerdown(bus) only once in ssb_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240925182739.5c9ca063@barney>
Date: Wed, 25 Sep 2024 18:27:39 +0200
From: Michael Büsch <m@...s.ch>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-wireless@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ssb: Call ssb_bus_may_powerdown(bus) only once in
 ssb_bus_register()

On Tue, 24 Sep 2024 21:33:49 +0200
Markus Elfring <Markus.Elfring@....de> wrote:

> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index aa6165e3db4a..458858b5472e 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -663,11 +663,9 @@ ssb_bus_register(struct ssb_bus *bus,
>  	ssb_extif_init(&bus->extif);
>  	ssb_mipscore_init(&bus->mipscore);
>  	err = ssb_fetch_invariants(bus, get_invariants);
> -	if (err) {
> -		ssb_bus_may_powerdown(bus);
> -		goto err_pcmcia_exit;
> -	}
>  	ssb_bus_may_powerdown(bus);
> +	if (err)
> +		goto err_pcmcia_exit;
> 
>  	/* Queue it for attach.
>  	 * See the comment at the ssb_is_early_boot definition.


Acked-by: Michael Büsch <m@...s.ch>


-- 
Michael Büsch
https://bues.ch/

Content of type "application/pgp-signature" skipped