linux-kernel - Re: [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvRUGvX9ZL4YVeMf@lizhi-Precision-Tower-5810>
Date: Wed, 25 Sep 2024 14:19:06 -0400
From: Frank Li <Frank.li@....com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop
 "interrupt-controller" property

On Wed, Sep 25, 2024 at 12:34:38PM -0500, Rob Herring (Arm) wrote:
> The Freescale MU-MSI is an MSI provider, not an interrupt provider, so
> drop the "interrupt-controller" property. This fixes dtc "interrupt_provider"
> warning.
>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
> If this is not correct, then #interrupt-cells needs to be added.
> ---
>  .../devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml  | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> index 799ae5c3e32a..b5282c857f44 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> @@ -62,8 +62,6 @@ properties:
>        - const: processor-a-side
>        - const: processor-b-side
>
> -  interrupt-controller: true
> -
>    msi-controller: true
>
>    "#msi-cells":
> @@ -73,7 +71,6 @@ required:
>    - compatible
>    - reg
>    - interrupts
> -  - interrupt-controller
>    - msi-controller
>    - "#msi-cells"
>
> @@ -88,7 +85,6 @@ examples:
>          compatible = "fsl,imx6sx-mu-msi";
>          msi-controller;
>          #msi-cells = <0>;
> -        interrupt-controller;
>          reg = <0x5d270000 0x10000>,     /* A side */
>                <0x5d300000 0x10000>;     /* B side */
>          reg-names = "processor-a-side", "processor-b-side";
> --
> 2.45.2
>