[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240925192711.GE30399@pendragon.ideasonboard.com>
Date: Wed, 25 Sep 2024 22:27:11 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Guenter Roeck <linux@...ck-us.net>,
Tomasz Figa <tfiga@...omium.org>,
Alan Stern <stern@...land.harvard.edu>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
Sean Paul <seanpaul@...omium.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCH v6 4/4] media: uvcvideo: Exit early if there is not
int_urb
Hi Ricardo,
Thank you for the patch.
On Fri, Jun 14, 2024 at 12:41:30PM +0000, Ricardo Ribalda wrote:
> If there is no int_urb there is no need to do a clean stop.
>
> Also we avoid calling usb_kill_urb(NULL). It is properly handled by the
> usb framework, but it is not polite.
>
> Now that we are at it, fix the code style in uvc_status_start() for
> consistency.
>
> Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
> drivers/media/usb/uvc/uvc_status.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_status.c b/drivers/media/usb/uvc/uvc_status.c
> index 8fd8250110e2..9108522beea6 100644
> --- a/drivers/media/usb/uvc/uvc_status.c
> +++ b/drivers/media/usb/uvc/uvc_status.c
> @@ -308,7 +308,7 @@ static int __uvc_status_start(struct uvc_device *dev, gfp_t flags)
> {
> lockdep_assert_held(&dev->status_lock);
>
> - if (dev->int_urb == NULL)
> + if (!dev->int_urb)
> return 0;
>
> return usb_submit_urb(dev->int_urb, flags);
> @@ -320,6 +320,9 @@ static void __uvc_status_stop(struct uvc_device *dev)
>
> lockdep_assert_held(&dev->status_lock);
>
> + if (!dev->int_urb)
> + return;
> +
> /*
> * Prevent the asynchronous control handler from requeing the URB. The
> * barrier is needed so the flush_status change is visible to other
>
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists