linux-kernel - Re: [PATCH net v4 0/2] bpf: devmap: provide rxq after redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97229412-7506-4b71-b77a-0993b2f07c60@linux.dev>
Date: Wed, 25 Sep 2024 12:45:34 -0700
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: Paolo Abeni <pabeni@...hat.com>,
 Florian Kauer <florian.kauer@...utronix.de>
Cc: Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Andrii Nakryiko <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
 Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 Toke Høiland-Jørgensen <toke@...hat.com>,
 David Ahern <dsahern@...nel.org>, Hangbin Liu <liuhangbin@...il.com>,
 Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
 netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jesper Dangaard Brouer <brouer@...hat.com>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net v4 0/2] bpf: devmap: provide rxq after redirect

On 9/19/24 11:12 AM, Paolo Abeni wrote:
> On 9/11/24 10:41, Florian Kauer wrote:
>> rxq contains a pointer to the device from where
>> the redirect happened. Currently, the BPF program
>> that was executed after a redirect via BPF_MAP_TYPE_DEVMAP*
>> does not have it set.
>>
>> Add bugfix and related selftest.
>>
>> Signed-off-by: Florian Kauer <florian.kauer@...utronix.de>
>> ---
>> Changes in v4:
>> - return -> goto out_close, thanks Toke
>> - Link to v3: https://lore.kernel.org/r/20240909-devel-koalo-fix-ingress- 
>> ifindex-v3-0-66218191ecca@...utronix.de
>>
>> Changes in v3:
>> - initialize skel to NULL, thanks Stanislav
>> - Link to v2: https://lore.kernel.org/r/20240906-devel-koalo-fix-ingress- 
>> ifindex-v2-0-4caa12c644b4@...utronix.de
>>
>> Changes in v2:
>> - changed fixes tag
>> - added selftest
>> - Link to v1: https://lore.kernel.org/r/20240905-devel-koalo-fix-ingress- 
>> ifindex-v1-1-d12a0d74c29c@...utronix.de
>>
>> ---
>> Florian Kauer (2):
>>        bpf: devmap: provide rxq after redirect
>>        bpf: selftests: send packet to devmap redirect XDP
>>
>>   kernel/bpf/devmap.c                                |  11 +-
>>   .../selftests/bpf/prog_tests/xdp_devmap_attach.c   | 114 +++++++++++++++++++--
>>   2 files changed, 115 insertions(+), 10 deletions(-)
> 
> Alex, Daniel: this will go directly via the bpf tree, right?

The patches lgtm also. Yes, it can directly go to the bpf tree.

It is useful if I can get an ack from netdev (Paolo?) at least for patch 1. Thanks.