linux-kernel - Re: [GIT PULL] HID for 6.12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73f1a21c-1db1-49ce-951e-a2694567c1c6@kernel.org>
Date: Wed, 25 Sep 2024 21:53:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jiri Kosina <jikos@...nel.org>,
 Linus Torvalds <torvalds@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, Benjamin Tissoires <bentiss@...nel.org>,
 Charles Wang <charles.goodix@...il.com>
Subject: Re: [GIT PULL] HID for 6.12

On 18/09/2024 15:04, Jiri Kosina wrote:
> Linus,
> 
> please pull from
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git tags/hid-for-linus-2024091602
> 
> 
> to receive HID subsystem queue for 6.12 merge window, namely:
> 
> =====
> 
> - New HID over SPI driver for Goodix devices that don't follow Microsoft's 
>   HID-over-SPI specification, so a separate driver is needed. Currently 
>   supported device is GT7986U touchscreen (Charles Wang)
> 
> - support for new hardware features in Wacom driver (high-res wheel 
>   scrolling, touchstrings with relative motions, support for two 
>   touchrings) (Jason Gerecke)
> 
> - support for customized vendor firmware loading in intel-ish driver 
>   (Zhang Lixu)
> 
> - fix for theoretical race condition in i2c-hid (Dmitry Torokhov)
> 
> - support for HIDIOCREVOKE -- evdev's EVIOCREVOKE equivalent in hidraw 
>   (Peter Hutterer)
> 
> - initial hidraw selftest implementation (Benjamin Tissoires)
> 
> - constification of device-specific report descriptors (Thomas Weißschuh)
> 
> - other small assorted fixes and device ID / quirk additions
> 
> =====
> 
> Thanks.
> 
> ----------------------------------------------------------------
> Benjamin Tissoires (4):
>       HID: samples: fix the 2 struct_ops definitions
>       selftests/hid: extract the utility part of hid_bpf.c into its own header
>       selftests/hid: Add initial hidraw tests skeleton
>       selftests/hid: Add HIDIOCREVOKE tests
> 
> Charles Wang (2):
>       HID: hid-goodix: Add Goodix HID-over-SPI driver
>       dt-bindings: input: Goodix SPI HID Touchscreen

On September 6, Rob reported that this is broken and should be fixed or
reverted.
https://lore.kernel.org/all/CAL_Jsq+QfTtRj_JCqXzktQ49H8VUnztVuaBjvvkg3fwEHniUHw@mail.gmail.com/

On September 10, Rob reminded that it is still broken.

Author ignored the problem, so the maintainer should revert this.. or at
least not send these further for RC inclusion.

If no one wants to fix this code, no one cares, we are not supposed to
take it into kernel release, right?

I just sent a revert, because this is now an issue in Linus' tree.

Best regards,
Krzysztof