linux-kernel - Re: [PATCH 2/2] dt-bindings: input: Revert "dt-bindings: input: Goodix SPI HID Touchscreen"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2409252306420.31206@cbobk.fhfr.pm>
Date: Wed, 25 Sep 2024 23:07:09 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>, 
    Krzysztof Kozlowski <krzk+dt@...nel.org>, 
    Conor Dooley <conor+dt@...nel.org>, 
    Benjamin Tissoires <bentiss@...nel.org>, 
    Charles Wang <charles.goodix@...il.com>, linux-input@...r.kernel.org, 
    devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: input: Revert "dt-bindings: input:
 Goodix SPI HID Touchscreen"

On Wed, 25 Sep 2024, Krzysztof Kozlowski wrote:

> This reverts commit 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID
> Touchscreen") because it duplicates existing binding leadings to errors:
> 
>   goodix,gt7986u.example.dtb:
>   touchscreen@0: compatible: 'oneOf' conditional failed, one must be fixed:
>         ['goodix,gt7986u'] is too short
>         'goodix,gt7375p' was expected
> 
> This was reported on mailing list on 6th of September, but no reaction
> happened from contributor or maintainer to fix it.
> 
> Therefore let's drop binding which breaks and duplicates existing one.
> 
> Fixes: 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID Touchscreen")
> Reported-by: Rob Herring <robh@...nel.org>
> Closes: https://lore.kernel.org/all/CAL_Jsq+QfTtRj_JCqXzktQ49H8VUnztVuaBjvvkg3fwEHniUHw@mail.gmail.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

I've applied both patches now and will expedite them to Linus.

Thanks,

-- 
Jiri Kosina
SUSE Labs