linux-kernel - Re: [PATCH] mm/memory_hotplug: Print the correct pfn in do_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f48a487-f8b0-7a0a-069a-78706413bd22@fujitsu.com>
Date: Wed, 25 Sep 2024 08:01:51 +0000
From: "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
To: "anshuman.khandual@....com" <anshuman.khandual@....com>
CC: "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"david@...hat.com" <david@...hat.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>, "osalvador@...e.de"
	<osalvador@...e.de>
Subject: Re: [PATCH] mm/memory_hotplug: Print the correct pfn in
 do_migrate_range()

Sorry for the late reply. (My company's mail server that enabling the 
DRMAC, seems not to deliver some mails to my inbox, I have to check 
mails in lore)

> On 9/24/24 15:45, Li Zhijian wrote:
> > The pfn value needs to be retrieved correctly when PageTransHuge(page)   
> Where the pfn could have been modified with
> pfn = page_to_pfn(head) + compound_nr(head) - 1
> So retrieving from page will get the original pfn value ?

Yes, that's true.
it should print the actual pfn thatfailed to isolate,\\\ Thanks Zhijian
  

>
>
> > is true. Fix it by replacing the usage of 'pfn' with 'page_to_pfn(page)' > to ensure the correct pfn is printed in warning messages when 
> isolation > fails. > > Signed-off-by: Li Zhijian 
> <lizhijian@...itsu.com> > --- > mm/memory_hotplug.c | 2 +- > 1 file 
> changed, 1 insertion(+), 1 deletion(-) > > diff --git 
> a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 
> 26790c8d5b43..000430406a9e 100644 > --- a/mm/memory_hotplug.c > +++ 
> b/mm/memory_hotplug.c > @@ -1829,7 +1829,7 @@ static void 
> do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > } 
> else { > if (__ratelimit(&migrate_rs)) { > - pr_warn("failed to 
> isolate pfn %lx\n", pfn); > + pr_warn("failed to isolate pfn %lx\n", 
> page_to_pfn(page)); > dump_page(page, "isolation failed"); > } > }