linux-kernel - Re: [v1,1/1] i2c: mediatek: add runtime PM operations and bus regulator control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <duauce4b6hlugfo6yelviaflkktfaix6g2kd2yqgdv5o36nhh4@despelul5fq5>
Date: Wed, 25 Sep 2024 10:18:24 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: "zoie.lin" <zoie.lin@...iatek.com>, Qii Wang <qii.wang@...iatek.com>, 
	Matthias Brugger <matthias.bgg@...il.com>, Project_Global_Chrome_Upstream_Group@...iatek.com, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [v1,1/1] i2c: mediatek: add runtime PM operations and bus
 regulator control

Hi,

...

> > @@ -1486,19 +1530,22 @@ static int mtk_i2c_probe(struct platform_device *pdev)
> >   	if (ret < 0) {
> >   		dev_err(&pdev->dev,
> >   			"Request I2C IRQ %d fail\n", irq);
> > -		goto err_bulk_unprepare;
> > +		goto err_clk_bulk_unprepare;
> >   	}
> > +	pm_runtime_set_autosuspend_delay(&pdev->dev, 1000);
> 
> One full second as autosuspend delay? Can this be shortened to 500? 250?
> 
> How was the one second wait chosen?
> 
> How much time does mtk_i2c_runtime_resume() take to resume the bus?

Besides that, please add a comment to explain why you chose
1000/500/250. Arbitrary values are not much appreciated.

Thanks,
Andi