linux-kernel - Re: [PATCH REVIEW 1/2] ASoC: codecs: lpass-rx-macro: fix RXn(rx,n) macro for DSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvPPpfobvDmmTCfi@finisterre.sirena.org.uk>
Date: Wed, 25 Sep 2024 10:53:57 +0200
From: Mark Brown <broonie@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Alexey Klimov <alexey.klimov@...aro.org>,
	srinivas.kandagatla@...aro.org, a39.skl@...il.com,
	linux-sound@...r.kernel.org, lgirdwood@...il.com, perex@...ex.cz,
	tiwai@...e.com, alsa-devel@...a-project.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	krzysztof.kozlowski@...aro.org, vkoul@...nel.org,
	klimov.linux@...il.com
Subject: Re: [PATCH REVIEW 1/2] ASoC: codecs: lpass-rx-macro: fix RXn(rx,n)
 macro for DSM_CTL and SEC7 regs

On Wed, Sep 25, 2024 at 11:27:54AM +0300, Dmitry Baryshkov wrote:
> On Wed, Sep 25, 2024 at 05:38:22AM GMT, Alexey Klimov wrote:

> > +#define CDC_RX_RXn_RX_PATH_SEC7(rx, n)		\
> > +	(0x0434 + rx->rxn_reg_stride * n + n * (n - 1) * rx->rxn_reg_stride2)

> This is a nice hack to rule out n=0 and n=1, but maybe we can be more
> obvious here:

> (0x0434 + stride * n + (n > 2) ? stride2 : 0)

Yes.  We could also use some brackets to make the + and * precedence
obvious.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)