linux-kernel - Re: [PATCH v4 01/16] module: Take const arg in validate_section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d56f36da-afd9-4956-8b74-8b0b17baadf2@samsung.com>
Date: Wed, 25 Sep 2024 11:00:28 +0200
From: Daniel Gomez <da.gomez@...sung.com>
To: Matthew Maurer <mmaurer@...gle.com>, <masahiroy@...nel.org>,
	<ndesaulniers@...gle.com>, <ojeda@...nel.org>, <gary@...yguo.net>,
	<mcgrof@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>
CC: <rust-for-linux@...r.kernel.org>, <linux-kbuild@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <neal@...pa.dev>, <marcan@...can.st>,
	<j@...nau.net>, <asahi@...ts.linux.dev>, Petr Pavlu <petr.pavlu@...e.com>,
	Sami Tolvanen <samitolvanen@...gle.com>, Boqun Feng <boqun.feng@...il.com>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
	<benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, Alice
	Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	<linux-modules@...r.kernel.org>
Subject: Re: [PATCH v4 01/16] module: Take const arg in
 validate_section_offset

On 9/24/2024 11:19 PM, Matthew Maurer wrote:
> `validate_section_offset` doesn't modify the info passed in. Make this
> clear by adjusting the type signature.
> 
> Signed-off-by: Matthew Maurer <mmaurer@...gle.com>
> ---
>   kernel/module/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index 49b9bca9de12..1a2dd52147ba 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -1645,7 +1645,7 @@ bool __weak module_exit_section(const char *name)
>   	return strstarts(name, ".exit");
>   }
>   
> -static int validate_section_offset(struct load_info *info, Elf_Shdr *shdr)
> +static int validate_section_offset(const struct load_info *info, Elf_Shdr *shdr)
>   {
>   #if defined(CONFIG_64BIT)
>   	unsigned long long secend;


The cover letter is missing a From/Cc to the linux-modules list. So I 
was missing the context here. Looking at lore I found it here:

https://lore.kernel.org/asahi/20240924212024.540574-1-mmaurer@google.com/

Can you add linux-modules list in case there's a next revision?

Also, the cover letter is missing a full changelog other than a 
reference to the previous discussions and to the last changes.

Daniel