linux-kernel - Re: [PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpoFpiyBC9eTY8tLyaV5Lqr-YjxckK22Twxae0kGYOWz4A@mail.gmail.com>
Date: Wed, 25 Sep 2024 11:06:57 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jingyi Wang <quic_jingyw@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Mathieu Poirier <mathieu.poirier@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, quic_tengfan@...cinc.com, 
	linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Xin Liu <quic_liuxin@...cinc.com>
Subject: Re: [PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document
 QCS8300 remoteproc

On Wed, 25 Sept 2024 at 10:35, Jingyi Wang <quic_jingyw@...cinc.com> wrote:
>
>
>
> On 9/25/2024 4:01 PM, Dmitry Baryshkov wrote:
> > On Wed, Sep 25, 2024 at 03:21:37PM GMT, Jingyi Wang wrote:
> >> Document the components used to boot the ADSP, CDSP and GPDSP on the
> >> Qualcomm QCS8300 SoC. Use fallback to indicate the compatibility of the
> >> remoteproc on the QCS8300 with that on the SA8775P.
>
> Hi Dmitry,
>
> >
> > Are there any SoC-specific quirks that demand a separate compat string?
> >
> > In other similar cases (sm8250 vs qrb5165, sc7280 vs qcm6490 vs qcs6490
> > we are adding new compatibles only if it is expected that the hardware
> > (or firmware) is actually different.
> >
>
> This case is different from the cases above as qcs8300 and sa8775p are
> different SoCs.(sm8250 and qrb5165 are different variants for the same
> SoC). QCS8300 has one cdsp&gpdsp while SA8775P has 2, but they share the
> same driver data, we used to discuss with Krzysztof how to deal case
> like this and got the following suggestion to use fallback in yaml:
> https://lore.kernel.org/all/6652a08e-7143-4214-a864-9f27c10d7571@kernel.org/

Ack, excuse me. I got confused by qcs8300 vs qcs9100.

>
> >> Co-developed-by: Xin Liu <quic_liuxin@...cinc.com>
> >> Signed-off-by: Xin Liu <quic_liuxin@...cinc.com>
> >> Signed-off-by: Jingyi Wang <quic_jingyw@...cinc.com>
> >> ---
> >> Changes in v3:
> >> - add "contains" and remove redundant compatible.
> >> - Link to v2: https://lore.kernel.org/r/20240911-qcs8300_remoteproc_binding-v2-1-01921b110532@quicinc.com
> >>
> >> Changes in v2:
> >> - decoupled from the original series.
> >> - Use fallback to indicate compatibility with SA8775P.
> >> - Link to v1: https://lore.kernel.org/r/20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com
> >> ---
> >>  .../bindings/remoteproc/qcom,sa8775p-pas.yaml      | 44 +++++++++++++++-------
> >>  1 file changed, 30 insertions(+), 14 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
> >> index 7fe401a06805..a66007951d58 100644
> >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
> >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
> >> @@ -15,12 +15,25 @@ description:
> >>
> >>  properties:
> >>    compatible:
> >> -    enum:
> >> -      - qcom,sa8775p-adsp-pas
> >> -      - qcom,sa8775p-cdsp0-pas
> >> -      - qcom,sa8775p-cdsp1-pas
> >> -      - qcom,sa8775p-gpdsp0-pas
> >> -      - qcom,sa8775p-gpdsp1-pas
> >> +    oneOf:
> >> +      - items:
> >> +          - enum:
> >> +              - qcom,qcs8300-adsp-pas
> >> +          - const: qcom,sa8775p-adsp-pas
> >> +      - items:
> >> +          - enum:
> >> +              - qcom,qcs8300-cdsp-pas
> >> +          - const: qcom,sa8775p-cdsp0-pas
> >> +      - items:
> >> +          - enum:
> >> +              - qcom,qcs8300-gpdsp-pas
> >> +          - const: qcom,sa8775p-gpdsp0-pas
> >> +      - enum:
> >> +          - qcom,sa8775p-adsp-pas
> >> +          - qcom,sa8775p-cdsp0-pas
> >> +          - qcom,sa8775p-cdsp1-pas
> >> +          - qcom,sa8775p-gpdsp0-pas
> >> +          - qcom,sa8775p-gpdsp1-pas
> >>
> >>    reg:
> >>      maxItems: 1
> >> @@ -63,8 +76,9 @@ allOf:
> >>    - if:
> >>        properties:
> >>          compatible:
> >> -          enum:
> >> -            - qcom,sa8775p-adsp-pas
> >> +          contains:
> >> +            enum:
> >> +              - qcom,sa8775p-adsp-pas
> >>      then:
> >>        properties:
> >>          power-domains:
> >> @@ -79,9 +93,10 @@ allOf:
> >>    - if:
> >>        properties:
> >>          compatible:
> >> -          enum:
> >> -            - qcom,sa8775p-cdsp0-pas
> >> -            - qcom,sa8775p-cdsp1-pas
> >> +          contains:
> >> +            enum:
> >> +              - qcom,sa8775p-cdsp0-pas
> >> +              - qcom,sa8775p-cdsp1-pas
> >>      then:
> >>        properties:
> >>          power-domains:
> >> @@ -98,9 +113,10 @@ allOf:
> >>    - if:
> >>        properties:
> >>          compatible:
> >> -          enum:
> >> -            - qcom,sa8775p-gpdsp0-pas
> >> -            - qcom,sa8775p-gpdsp1-pas
> >> +          contains:
> >> +            enum:
> >> +              - qcom,sa8775p-gpdsp0-pas
> >> +              - qcom,sa8775p-gpdsp1-pas
> >>      then:
> >>        properties:
> >>          power-domains:
> >>
> >> ---
> >> base-commit: 4d0326b60bb753627437fff0f76bf1525bcda422
> >> change-id: 20240925-qcs8300_remoteproc_binding-a2837bab2150
> >>
> >> Best regards,
> >> --
> >> Jingyi Wang <quic_jingyw@...cinc.com>
> >>
> >
> Thanks,
> Jingyi
>


-- 
With best wishes
Dmitry