linux-kernel - Re: [PATCH v8 00/11] fs: multigrain timestamp redux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fadc1ea2-fb43-41e2-af8c-8a93cf9e7865@infradead.org>
Date: Thu, 26 Sep 2024 09:59:21 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Jeff Layton <jlayton@...nel.org>, John Stultz <jstultz@...gle.com>,
 Thomas Gleixner <tglx@...utronix.de>, Stephen Boyd <sboyd@...nel.org>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Jonathan Corbet <corbet@....net>, Chandan Babu R <chandan.babu@...cle.com>,
 "Darrick J. Wong" <djwong@...nel.org>, Theodore Ts'o <tytso@....edu>,
 Andreas Dilger <adilger.kernel@...ger.ca>, Chris Mason <clm@...com>,
 Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>,
 Hugh Dickins <hughd@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>,
 Chuck Lever <chuck.lever@...cle.com>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org,
 linux-btrfs@...r.kernel.org, linux-nfs@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v8 00/11] fs: multigrain timestamp redux

Hi Jeff,

On 9/14/24 10:07 AM, Jeff Layton wrote:
> This is a fairly small update to the v7 set. It seems to pass all of my
> testing. Again, most of the changes are in the first two patches, but
> there are some differences in the patch that adds percpu counters as
> well.
> 
> Since the report of a performance regression came just before the merge
> window, it looks like we're going to have to wait for yet another
> release, so consider this version v6.13 material.
> 
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---

> ---
> Jeff Layton (11):
>       timekeeping: move multigrain timestamp floor handling into timekeeper
>       fs: add infrastructure for multigrain timestamps
>       fs: have setattr_copy handle multigrain timestamps appropriately
>       fs: handle delegated timestamps in setattr_copy_mgtime
>       fs: tracepoints around multigrain timestamp events
>       fs: add percpu counters for significant multigrain timestamp events
>       Documentation: add a new file documenting multigrain timestamps
>       xfs: switch to multigrain timestamps
>       ext4: switch to multigrain timestamps
>       btrfs: convert to multigrain timestamps
>       tmpfs: add support for multigrain timestamps
> 
>  Documentation/filesystems/index.rst         |   1 +
>  Documentation/filesystems/multigrain-ts.rst | 121 ++++++++++++
>  fs/attr.c                                   |  60 +++++-
>  fs/btrfs/file.c                             |  25 +--
>  fs/btrfs/super.c                            |   3 +-
>  fs/ext4/super.c                             |   2 +-
>  fs/inode.c                                  | 278 +++++++++++++++++++++++++---
>  fs/stat.c                                   |  42 ++++-
>  fs/xfs/libxfs/xfs_trans_inode.c             |   6 +-
>  fs/xfs/xfs_iops.c                           |  10 +-
>  fs/xfs/xfs_super.c                          |   2 +-
>  include/linux/fs.h                          |  36 +++-
>  include/linux/timekeeping.h                 |   5 +
>  include/trace/events/timestamp.h            | 124 +++++++++++++
>  kernel/time/timekeeping.c                   |  83 +++++++++
>  kernel/time/timekeeping_debug.c             |  12 ++
>  kernel/time/timekeeping_internal.h          |   3 +
>  mm/shmem.c                                  |   2 +-
>  18 files changed, 742 insertions(+), 73 deletions(-)
> ---
> base-commit: da3ea35007d0af457a0afc87e84fddaebc4e0b63

IME it would be better to make this series apply to linux-next-($latest)
instead of base mainline Linux. for integration reasons.

You can add

Tested-by: Randy Dunlap <rdunlap@...radead.org> # documentation bits

for all patches if you want to.

> change-id: 20240913-mgtime-20c98bcda88e
> 
> Best regards,