linux-kernel - Re: [PATCH v4 3/9] platform/x86: asus-armoury: move existing tunings to asus-armoury module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08320b8e-a71b-4055-9fdf-1df76530ec1a@web.de>
Date: Thu, 26 Sep 2024 21:10:56 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: "Luke D. Jones" <luke@...nes.dev>, platform-driver-x86@...r.kernel.org,
 linux-input@...r.kernel.org, Benjamin Tissoires <bentiss@...nel.org>,
 Corentin Chary <corentin.chary@...il.com>,
 Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Jiri Kosina <jikos@...nel.org>, Mario Limonciello <superm1@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/9] platform/x86: asus-armoury: move existing tunings
 to asus-armoury module

…
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -0,0 +1,146 @@
…
> +#ifndef _ASUS_BIOSCFG_H_
> +#define _ASUS_BIOSCFG_H_
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus