linux-kernel - Re: [PATCH 3/5] x86/pvh: Omit needless clearing of phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <411b7339-7cdf-441f-acba-550fe79ce408@amd.com>
Date: Thu, 26 Sep 2024 16:35:14 -0400
From: Jason Andryuk <jason.andryuk@....com>
To: Ard Biesheuvel <ardb+git@...gle.com>, <linux-kernel@...r.kernel.org>
CC: Ard Biesheuvel <ardb@...nel.org>, Juergen Gross <jgross@...e.com>, "Boris
 Ostrovsky" <boris.ostrovsky@...cle.com>, <x86@...nel.org>,
	<xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH 3/5] x86/pvh: Omit needless clearing of phys_base

On 2024-09-26 06:41, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@...nel.org>
> 
> Since commit
> 
>    d9ec1158056b ("x86/boot/64: Use RIP_REL_REF() to assign 'phys_base'")
> 
> phys_base is assigned directly rather than added to, so it is no longer
> necessary to clear it after use.
> 
> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>

Reviewed-by: Jason Andryuk <jason.andryuk@....com>
Tested-by: Jason Andryuk <jason.andryuk@....com>

My patch pre-dated the above, but I never liked it.  Happy to see this gone.

Thanks,
Jason