linux-kernel - Re: [PATCH v5 5/6] mips: dts: realtek: Add I2C controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d39d12b-a206-46e2-b3fa-001914a68165@alliedtelesis.co.nz>
Date: Thu, 26 Sep 2024 20:52:17 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "andi.shyti@...nel.org" <andi.shyti@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "lee@...nel.org"
	<lee@...nel.org>, "sre@...nel.org" <sre@...nel.org>,
	"tsbogend@...ha.franken.de" <tsbogend@...ha.franken.de>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH v5 5/6] mips: dts: realtek: Add I2C controllers


On 26/09/24 18:37, Krzysztof Kozlowski wrote:
> On Thu, Sep 26, 2024 at 09:58:46AM +1200, Chris Packham wrote:
>> Add the I2C controllers that are part of the RTL9300 SoC.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>>
>> Notes:
>>      Changes in v5:
>>      - Update compatibles
>>      Changes in v4:
>>      - Skipped due to combining patch series
>>      Changes in v3:
>>      - None
>>      Changes in v2:
>>      - Use reg property
>>
>>   arch/mips/boot/dts/realtek/rtl9302c.dtsi |  8 ++++++++
>>   arch/mips/boot/dts/realtek/rtl930x.dtsi  | 16 ++++++++++++++++
>>   2 files changed, 24 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/realtek/rtl9302c.dtsi b/arch/mips/boot/dts/realtek/rtl9302c.dtsi
>> index 80d9f407e758..56c35e8b8b62 100644
>> --- a/arch/mips/boot/dts/realtek/rtl9302c.dtsi
>> +++ b/arch/mips/boot/dts/realtek/rtl9302c.dtsi
>> @@ -5,3 +5,11 @@
>>   &switch0 {
>>   	compatible = "realtek,rtl9302c-switch", "realtek,rtl9300-switch", "syscon", "simple-mfd";
>>   };
>> +
>> +&i2c0 {
>> +	compatible = "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c";
>> +};
>> +
>> +&i2c1 {
>> +	compatible = "realtek,rtl9302c-i2c", "realtek,rtl9300-i2c";
>> +};
>> diff --git a/arch/mips/boot/dts/realtek/rtl930x.dtsi b/arch/mips/boot/dts/realtek/rtl930x.dtsi
>> index 89b8854596cd..2fb8461af575 100644
>> --- a/arch/mips/boot/dts/realtek/rtl930x.dtsi
>> +++ b/arch/mips/boot/dts/realtek/rtl930x.dtsi
>> @@ -41,6 +41,22 @@ reboot@c {
>>   			reg = <0x0c 0x4>;
>>   			value = <0x01>;
>>   		};
>> +
>> +		i2c0: i2c@36c {
>> +			compatible = "realtek,rtl9300-i2c";
>> +			reg = <0x36c 0x14>;
>> +			status = "disabled";
> Usual convention is to have status the last. Maybe MIPS has different,
> so keep whatever is consistent in your case.

I'll send out a fixup patch that can be folded into this. Hopefully 
Thomas can combine them at his end (or if there is a need for a v6 I can).

I'll probably have other series touching this file so if the fixup 
doesn't make it now I can include it in a future series.

>
> Anyway:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> Best regards,
> Krzysztof
>