linux-kernel - Re: [PATCH] bpf: Call kfree(obj) only once in free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d594f27e7782b318b8eb90fef202d4cfdce59da4.camel@gmail.com>
Date: Thu, 26 Sep 2024 16:21:30 -0700
From: Eduard Zingerman <eddyz87@...il.com>
To: Markus Elfring <Markus.Elfring@....de>, bpf@...r.kernel.org, Andrii
 Nakryiko <andrii@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Hao Luo <haoluo@...gle.com>, Hou Tao
 <houtao1@...wei.com>,  Jiri Olsa <jolsa@...nel.org>, John Fastabend
 <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,  Martin KaFai
 Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Stanislav Fomichev
 <sdf@...ichev.me>,  Yonghong Song <yonghong.song@...ux.dev>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] bpf: Call kfree(obj) only once in free_one()

On Thu, 2024-09-26 at 13:45 +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 26 Sep 2024 13:30:42 +0200
> 
> A kfree() call is always used at the end of this function implementation.
> Thus specify such a function call only once instead of duplicating it
> in a previous if branch.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---

Acked-by: Eduard Zingerman <eddyz87@...il.com>

[...]