linux-kernel - Re: [PATCH] perf test: Silence perf check subcommand when not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZvTysPPKxYKjUMTA@google.com>
Date: Wed, 25 Sep 2024 22:35:44 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: James Clark <james.clark@...aro.org>
Cc: Thomas Richter <tmricht@...ux.ibm.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org, acme@...nel.org,
	agordeev@...ux.ibm.com, gor@...ux.ibm.com, sumanthk@...ux.ibm.com,
	hca@...ux.ibm.com
Subject: Re: [PATCH] perf test: Silence perf check subcommand when not
 supported

On Wed, Sep 11, 2024 at 02:34:27PM +0100, James Clark wrote:
> 
> 
> On 11/09/2024 13:28, Thomas Richter wrote:
> > Perf subcommand check might not be supported and prints an
> > error message when used:
> 
> Only in verbose mode though. Personally I don't like all the piping to
> /dev/null in the tests because I have to go and remove them every time a
> test fails, rather than just doing "-v". But as it's pretty much the pattern
> used I suppose we should continue.
> 
> > 
> >   # perf check feature -q libtraceevent
> >   perf: 'check' is not a perf-command. See 'perf --help'.
> > 
> >   Did you mean one of these?
> >          c2c
> >          sched

I think perf test is supposed to run the latest build so perf check
command should be available.  Do you see this in the test result or just
in the command line?

Thanks,
Namhyung


> >   #
> > 
> > Drop this error message, the return code is sufficient.
> > 
> > Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>
> > ---
> >   tools/perf/tests/shell/lib/probe_vfs_getname.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/tests/shell/lib/probe_vfs_getname.sh b/tools/perf/tests/shell/lib/probe_vfs_getname.sh
> > index 5c33ec7a5a63..697fbe296a62 100644
> > --- a/tools/perf/tests/shell/lib/probe_vfs_getname.sh
> > +++ b/tools/perf/tests/shell/lib/probe_vfs_getname.sh
> > @@ -32,7 +32,7 @@ skip_if_no_debuginfo() {
> >   # check if perf is compiled with libtraceevent support
> >   skip_no_probe_record_support() {
> >   	if [ $had_vfs_getname -eq 1 ] ; then
> > -		perf check feature -q libtraceevent && return 1
> > +		perf check feature -q libtraceevent >/dev/null 2>&1 && return 1
> 
> There's another of the same in tools/perf/tests/shell/test_task_analyzer.sh
> 
> With that:
> 
> Reviewed-by: James Clark <james.clark@...aro.org>