linux-kernel - Re: [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555edaf290dd3dd4e1c3cc635b41de05ed4af350.camel@maquefel.me>
Date: Thu, 26 Sep 2024 09:44:14 +0300
From: Nikita Shubin <nikita.shubin@...uefel.me>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Alexander Sverdlin <alexander.sverdlin@...il.com>, Arnd Bergmann
	 <arnd@...db.de>, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski
	 <brgl@...ev.pl>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	 <conor+dt@...nel.org>
Subject: Re: [PATCH] dt-bindings: gpio: ep9301: Add missing
 "#interrupt-cells" to examples

Hi Rob!

Thank you!

Reviewed-by: Nikita Shubin <nikita.shubin@...uefel.me>

On Wed, 2024-09-25 at 12:35 -0500, Rob Herring (Arm) wrote:
> From: Rob Herring <robh@...nel.org>
> 
> Enabling dtc interrupt_provider check reveals the examples are
> missing
> the "#interrupt-cells" property as it is a dependency of
> "interrupt-controller".
> 
> Some of the indentation is off, so fix that too.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml | 9 ++++++--
> -
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> index daadfb4926c3..3a1079d6ee20 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> @@ -73,9 +73,10 @@ examples:
>        reg-names = "data", "dir", "intr";
>        gpio-controller;
>        #gpio-cells = <2>;
> -        interrupt-controller;
> -        interrupt-parent = <&vic1>;
> -        interrupts = <27>;
> +      interrupt-controller;
> +      #interrupt-cells = <2>;
> +      interrupt-parent = <&vic1>;
> +      interrupts = <27>;
>      };
>  
>      gpio@...40004 {
> @@ -87,6 +88,7 @@ examples:
>        gpio-controller;
>        #gpio-cells = <2>;
>        interrupt-controller;
> +      #interrupt-cells = <2>;
>        interrupt-parent = <&vic1>;
>        interrupts = <27>;
>      };
> @@ -127,6 +129,7 @@ examples:
>        gpio-controller;
>        #gpio-cells = <2>;
>        interrupt-controller;
> +      #interrupt-cells = <2>;
>        interrupts-extended = <&vic0 19>, <&vic0 20>,
>                              <&vic0 21>, <&vic0 22>,
>                              <&vic1 15>, <&vic1 16>,