linux-kernel - Re: [PATCH] dt-bindings: power/supply: qcom,pmi8998-char: Add missing "interrupt-controller" to example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bxxhgmcfxhzvf3m655gl3asiro6v6zaqrxeea3nlehyc54dl6f@3nvonnrzynpw>
Date: Thu, 26 Sep 2024 09:05:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Sebastian Reichel <sre@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Caleb Connolly <caleb.connolly@...aro.org>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: power/supply: qcom,pmi8998-char: Add
 missing "interrupt-controller" to example

On Wed, Sep 25, 2024 at 12:34:12PM -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing
> the "interrupt-controller" property as it is a dependency of
> "#interrupt-cells".
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  .../devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml   | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> index 277c47e048b6..a1b4926e7190 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> @@ -61,6 +61,7 @@ examples:
>        #address-cells = <1>;
>        #size-cells = <0>;
>        #interrupt-cells = <4>;
> +      interrupt-controller;

Opposite, the interrupt-cells should be dropped. The parent ("pmic") is
qcom,spmi-pmic.yaml which is not an interrupt controller, according to
the bindings.

Best regards,
Krzysztof