linux-kernel - Re: [PATCH 1/1] tty: n_gsm: Fix use-after-free in gsm_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <DB9PR10MB588133D6FD3E5FD70E15E5C4E06A2@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
Date: Thu, 26 Sep 2024 07:43:34 +0000
From: "Starke, Daniel" <daniel.starke@...mens.com>
To: "jirislaby@...nel.org" <jirislaby@...nel.org>
CC: Greg KH <gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-serial@...r.kernel.org"
	<linux-serial@...r.kernel.org>, "xialonglong@...inos.cn"
	<xialonglong@...inos.cn>
Subject: Re: [PATCH 1/1] tty: n_gsm: Fix use-after-free in gsm_cleanup_mux

> > [Analysis]
> > gsm_msg on the tx_ctrl_list or tx_data_list of gsm_mux
> > can be freed by multi threads through ioctl,which leads
> > to the occurrence of uaf. Protect it by gsm tx lock.
> 
> LGTM. But Daniel might have a different opinion...

Looks also good to me. I did not test it, but this will most likely solve
one of the many multi-threading issues in the n_gsm driver.

Best regards,
Daniel Starke