linux-kernel - RE: [PATCH 1/2] i2c: designware: determine HS tHIGH and tLOW based on HW paramters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA1PR14MB6224EAAD5566CC5288CDC0838A6A2@IA1PR14MB6224.namprd14.prod.outlook.com>
Date: Thu, 26 Sep 2024 08:45:47 +0000
From: Michael Wu <Michael.Wu@...ron.us>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Jarkko Nikula <jarkko.nikula@...ux.intel.com>, Mika Westerberg
	<mika.westerberg@...ux.intel.com>, Jan Dabros <jsd@...ihalf.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, Andi Shyti
	<andi.shyti@...nel.org>, morgan chang <morgan.chang@...ron.us>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] i2c: designware: determine HS tHIGH and tLOW based on
 HW paramters

> On Wed, Sep 25, 2024 at 12:16:10PM +0300, Andy Shevchenko wrote:
> > On Wed, Sep 25, 2024 at 04:04:30PM +0800, Michael Wu wrote:
> 
> ...
> 
> > > + * @bus_loading: for high speed mode, the bus loading affects the high
> and low
> > > + *	pulse width of SCL
> >
> > This is bad naming, better is bus_capacitance.
> 
> Even more specific bus_capacitance_pf as we usually add physical units to the
> variable names, so we immediately understand from the code the order of
> numbers and their physical meanings. 

Sounds good. However, I think the length of "bus_capacitance_pf" is a bit
long, we may often encounter the limit of more than 80 characters in a
line when coding. I'll rename it to "bus_cap_pf".

Thanks & Regards,
Michael