linux-kernel - Re: [PATCH] rust: KASAN+RETHUNK requires rustc 1.83.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mGsevNqECufBo6EP8cxFd=vwcXDpVdsgts-Ve0+mPkrg@mail.gmail.com>
Date: Thu, 26 Sep 2024 12:34:08 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: ojeda@...nel.org, a.hindborg@...sung.com, alex.gaynor@...il.com, 
	benno.lossin@...ton.me, bjorn3_gh@...tonmail.com, boqun.feng@...il.com, 
	bp@...en8.de, dave.hansen@...ux.intel.com, gary@...yguo.net, hpa@...or.com, 
	jpoimboe@...nel.org, linux-kernel@...r.kernel.org, masahiroy@...nel.org, 
	mingo@...hat.com, nathan@...nel.org, nicolas@...sle.eu, 
	patches@...ts.linux.dev, peterz@...radead.org, rust-for-linux@...r.kernel.org, 
	tglx@...utronix.de, x86@...nel.org
Subject: Re: [PATCH] rust: KASAN+RETHUNK requires rustc 1.83.0

On Thu, Sep 26, 2024 at 11:39 AM Alice Ryhl <aliceryhl@...gle.com> wrote:
>
> This is caused by the -Zfunction-return=thunk-extern flag in rustc not
> properly informing LLVM about the mitigation, which means that the KASAN

"...not informing LLVM about the mitigation at the module level (it
does so at the function level only currently, which covers most cases,
but both are required)" or similar?

> This is being fixed for rustc 1.83.0, so update Kconfig to reject this
> configuration on older compilers.

Yeah, let's go with 1.83.0 as we said -- we can modify it if needed
later on. I think the PR is fairly straightforward so it should
probably land in that version unless there is an unknown unknown.

Thanks Alice, looks good to me.

I will take this one soon.

Cheers,
Miguel