linux-kernel - Re: [PATCH 0/2] usb: typec: ucsi: ccg: Adjustments for common code in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpo0Q0Wn-GzqmPeNFfG_Hr-o8E7F_VuO47EbxKx=0OQhyQ@mail.gmail.com>
Date: Thu, 26 Sep 2024 14:20:19 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Markus Elfring <Markus.Elfring@....de>, linux-usb@...r.kernel.org, 
	Ajay Gupta <ajayg@...dia.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Haotien Hsu <haotienh@...dia.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
	Utkarsh Patel <utkarsh.h.patel@...el.com>, 
	Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
	Wolfram Sang <wsa@...-dreams.de>, LKML <linux-kernel@...r.kernel.org>, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 0/2] usb: typec: ucsi: ccg: Adjustments for common code in
 two functions

On Thu, 26 Sept 2024 at 14:12, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Thu, Sep 26, 2024 at 12:26:24AM +0300, Dmitry Baryshkov wrote:
> > On Wed, Sep 25, 2024 at 07:31:04PM GMT, Markus Elfring wrote:
> > > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > > Date: Wed, 25 Sep 2024 19:19:01 +0200
> > >
> > > A few update suggestions were taken into account
> > > from static source code analysis.
> > >
> > > Markus Elfring (2):
> > >   Use common code in ccg_write()
> > >   Use common code in ccg_read()
> > >
> > >  drivers/usb/typec/ucsi/ucsi_ccg.c | 15 ++++++++-------
> > >  1 file changed, 8 insertions(+), 7 deletions(-)
> >
> > For the series:
> >
> > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>
> I believe there is no-one to take it,

I guessed so.

> but in any case the thing is that kfree()
> probably can be done using __free(). Then PM runtime handled differently.

That's a separate cleanup in my opinion.

-- 
With best wishes
Dmitry