linux-kernel - Re: [PATCH] RISC-V: Fix building rust when using GCC toolchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240926-plated-guts-e84b822c40cc@spud>
Date: Thu, 26 Sep 2024 16:56:21 +0100
From: Conor Dooley <conor@...nel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Gary Guo <gary@...yguo.net>, Jason Montleon <jmontleo@...hat.com>,
	ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com,
	bjorn3_gh@...tonmail.com, benno.lossin@...ton.me,
	a.hindborg@...nel.org, aliceryhl@...gle.com,
	paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
	nathan@...nel.org, ndesaulniers@...gle.com, morbo@...gle.com,
	justinstitt@...gle.com, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
	llvm@...ts.linux.dev, stable@...r.kernel.org
Subject: Re: [PATCH] RISC-V: Fix building rust when using GCC toolchain

On Thu, Sep 26, 2024 at 05:40:19PM +0200, Miguel Ojeda wrote:
> On Tue, Sep 17, 2024 at 5:26 PM Conor Dooley <conor@...nel.org> wrote:
> >
> > Yes, but unfortunately I already knew how it worked. It's not flags I am worried about, it is extensions.
> > Even using a libclang that doesn't match clang could be a problem, but we can at least declare that unsupported.
> > Not digging it out on an airport bus, but we discussed the lack of GCC support on the original patch adding riscv, and decided against it.
> 
> Do you mean you would prefer to avoid supporting the mixed GCC-Clang
> builds?

Mixed builds are allowed on the c side, since we can figure out what the
versions of each tool are. If there's a way to detect the version of
libclang in use by the rust side, then I would be okay with mixed gcc +
rustc builds.

> If so, do you mean you would prefer to not pick the patch,
> i.e. avoid supporting this at all?

Yes, I would rather this was not applied at all. My plan was to send a
patch making HAVE_RUST depend on CC_IS_CLANG, but just ain't got around
to it yet, partly cos I was kinda hoping to mention this to you guys at
LPC last week, but I never got the chance to talk to any rust people (or
go to any rust talks either!).

> (If so, then perhaps it would be a
> good idea to add a comment there and perhaps a note to
> https://docs.kernel.org/rust/arch-support.html).

Sure, I can add a comment there. 

> Otherwise, please let me know if I am misunderstanding -- thanks!

In sorta related news, is there a plan for config "options" that will
allow us to detect gcc-rs or the gcc rust backend?

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)